Make WordPress Core


Ignore:
Timestamp:
06/22/2023 02:55:47 PM (13 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace usage of substr() with str_starts_with() and str_ends_with().

str_starts_with() and str_ends_with() were introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) begins or ends with the given substring (needle).

WordPress core includes a polyfill for these functions on PHP < 8.0 as of WordPress 5.9.

This commit uses str_starts_with() and str_ends_with() in core files where appropriate:

  • $needle === substr( $string, 0, $length ), where $length is the length of $needle, is replaced with str_starts_with( $haystack, $needle ).
  • $needle === substr( $string, $offset ), where $offset is negative and the absolute value of $offset is the length of $needle, is replaced with str_ends_with( $haystack, $needle ).

This aims to make the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987], [55988].

Props Soean, spacedmonkey, Clorith, ocean90, azaozz, sabernhardt, SergeyBiryukov.
Fixes #58220.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/ajax-actions.php

    r55988 r55990  
    33243324    remove_filter( 'media_send_to_editor', 'image_media_send_to_editor' );
    33253325
    3326     if ( 'image' === substr( $post->post_mime_type, 0, 5 ) ) {
     3326    if ( str_starts_with( $post->post_mime_type, 'image' ) ) {
    33273327        $align = isset( $attachment['align'] ) ? $attachment['align'] : 'none';
    33283328        $size  = isset( $attachment['image-size'] ) ? $attachment['image-size'] : 'medium';
Note: See TracChangeset for help on using the changeset viewer.