Changeset 55990 for trunk/src/wp-admin/includes/class-wp-screen.php

Timestamp:

06/22/2023 02:55:47 PM (5 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of substr() with str_starts_with() and str_ends_with().

str_starts_with() and str_ends_with() were introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) begins or ends with the given substring (needle).

WordPress core includes a polyfill for these functions on PHP < 8.0 as of WordPress 5.9.

This commit uses str_starts_with() and str_ends_with() in core files where appropriate:

• $needle === substr( $string, 0, $length ), where $length is the length of $needle, is replaced with str_starts_with( $haystack, $needle ).
• $needle === substr( $string, $offset ), where $offset is negative and the absolute value of $offset is the length of $needle, is replaced with str_ends_with( $haystack, $needle ).

This aims to make the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987], [55988].

Props Soean, spacedmonkey, Clorith, ocean90, azaozz, sabernhardt, SergeyBiryukov.
Fixes #58220.

File:

• trunk/src/wp-admin/includes/class-wp-screen.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-screen.php

@@ -231 +231 @@
             $id        = 'post'; // Changes later. Ends up being $base.
         } else {
-            if ( '.php' === substr( $id, -4 ) ) {
+            if ( str_ends_with( $id, '.php' ) ) {
                 $id = substr( $id, 0, -4 );
             }
@@ -242 +242 @@
 
         if ( ! $post_type && $hook_name ) {
-            if ( '-network' === substr( $id, -8 ) ) {
+            if ( str_ends_with( $id, '-network' ) ) {
                 $id       = substr( $id, 0, -8 );
                 $in_admin = 'network';
-            } elseif ( '-user' === substr( $id, -5 ) ) {
+            } elseif ( str_ends_with( $id, '-user' ) ) {
                 $id       = substr( $id, 0, -5 );
                 $in_admin = 'user';
@@ -251 +251 @@
 
             $id = sanitize_key( $id );
-            if ( 'edit-comments' !== $id && 'edit-tags' !== $id && 'edit-' === substr( $id, 0, 5 ) ) {
+            if ( 'edit-comments' !== $id && 'edit-tags' !== $id && str_starts_with( $id, 'edit-' ) ) {
                 $maybe = substr( $id, 5 );
                 if ( taxonomy_exists( $maybe ) ) {