Changeset 55990 for trunk/src/wp-admin/includes/media.php

Timestamp:

06/22/2023 02:55:47 PM (6 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace usage of substr() with str_starts_with() and str_ends_with().

str_starts_with() and str_ends_with() were introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) begins or ends with the given substring (needle).

WordPress core includes a polyfill for these functions on PHP < 8.0 as of WordPress 5.9.

This commit uses str_starts_with() and str_ends_with() in core files where appropriate:

• $needle === substr( $string, 0, $length ), where $length is the length of $needle, is replaced with str_starts_with( $haystack, $needle ).
• $needle === substr( $string, $offset ), where $offset is negative and the absolute value of $offset is the length of $needle, is replaced with str_ends_with( $haystack, $needle ).

This aims to make the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987], [55988].

Props Soean, spacedmonkey, Clorith, ocean90, azaozz, sabernhardt, SergeyBiryukov.
Fixes #58220.

File:

• trunk/src/wp-admin/includes/media.php (modified) (3 diffs)

trunk/src/wp-admin/includes/media.php

@@ -1355 +1355 @@
     $post = get_post( $attachment_id );
 
-    if ( 'image' === substr( $post->post_mime_type, 0, 5 ) ) {
+    if ( str_starts_with( $post->post_mime_type, 'image' ) ) {
         $url   = $attachment['url'];
         $align = ! empty( $attachment['align'] ) ? $attachment['align'] : 'none';
@@ -1466 +1466 @@
 
     // This was formerly in image_attachment_fields_to_edit().
-    if ( 'image' === substr( $post->post_mime_type, 0, 5 ) ) {
+    if ( str_starts_with( $post->post_mime_type, 'image' ) ) {
         $alt = get_post_meta( $post->ID, '_wp_attachment_image_alt', true );
 
@@ -3221 +3221 @@
     </div>
     <div class="wp_attachment_details edit-form-section">
-    <?php if ( 'image' === substr( $post->post_mime_type, 0, 5 ) ) : ?>
+    <?php if ( str_starts_with( $post->post_mime_type, 'image' ) ) : ?>
         <p class="attachment-alt-text">
             <label for="attachment_alt"><strong><?php _e( 'Alternative Text' ); ?></strong></label><br />