Make WordPress Core


Ignore:
Timestamp:
06/22/2023 02:55:47 PM (11 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace usage of substr() with str_starts_with() and str_ends_with().

str_starts_with() and str_ends_with() were introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) begins or ends with the given substring (needle).

WordPress core includes a polyfill for these functions on PHP < 8.0 as of WordPress 5.9.

This commit uses str_starts_with() and str_ends_with() in core files where appropriate:

  • $needle === substr( $string, 0, $length ), where $length is the length of $needle, is replaced with str_starts_with( $haystack, $needle ).
  • $needle === substr( $string, $offset ), where $offset is negative and the absolute value of $offset is the length of $needle, is replaced with str_ends_with( $haystack, $needle ).

This aims to make the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987], [55988].

Props Soean, spacedmonkey, Clorith, ocean90, azaozz, sabernhardt, SergeyBiryukov.
Fixes #58220.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/l10n.php

    r55928 r55990  
    11821182
    11831183    // Translations are always based on the unminified filename.
    1184     if ( substr( $relative, -7 ) === '.min.js' ) {
     1184    if ( str_ends_with( $relative, '.min.js' ) ) {
    11851185        $relative = substr( $relative, 0, -7 ) . '.js';
    11861186    }
     
    14551455            continue;
    14561456        }
    1457         if ( substr( $file, -3 ) !== '.po' ) {
     1457        if ( ! str_ends_with( $file, '.po' ) ) {
    14581458            continue;
    14591459        }
Note: See TracChangeset for help on using the changeset viewer.