Make WordPress Core


Ignore:
Timestamp:
06/22/2023 02:55:47 PM (12 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace usage of substr() with str_starts_with() and str_ends_with().

str_starts_with() and str_ends_with() were introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) begins or ends with the given substring (needle).

WordPress core includes a polyfill for these functions on PHP < 8.0 as of WordPress 5.9.

This commit uses str_starts_with() and str_ends_with() in core files where appropriate:

  • $needle === substr( $string, 0, $length ), where $length is the length of $needle, is replaced with str_starts_with( $haystack, $needle ).
  • $needle === substr( $string, $offset ), where $offset is negative and the absolute value of $offset is the length of $needle, is replaced with str_ends_with( $haystack, $needle ).

This aims to make the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987], [55988].

Props Soean, spacedmonkey, Clorith, ocean90, azaozz, sabernhardt, SergeyBiryukov.
Fixes #58220.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/ms-load.php

    r55412 r55990  
    4747    foreach ( $active_plugins as $plugin ) {
    4848        if ( ! validate_file( $plugin )                     // $plugin must validate as file.
    49             && '.php' === substr( $plugin, -4 )             // $plugin must end with '.php'.
     49            && str_ends_with( $plugin, '.php' )             // $plugin must end with '.php'.
    5050            && file_exists( WP_PLUGIN_DIR . '/' . $plugin ) // $plugin must exist.
    5151            ) {
     
    230230    // query for both to provide the proper redirect.
    231231    $domains = array( $domain );
    232     if ( 'www.' === substr( $domain, 0, 4 ) ) {
     232    if ( str_starts_with( $domain, 'www.' ) ) {
    233233        $domains[] = substr( $domain, 4 );
    234234    }
Note: See TracChangeset for help on using the changeset viewer.