Make WordPress Core


Ignore:
Timestamp:
06/22/2023 02:55:47 PM (12 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Replace usage of substr() with str_starts_with() and str_ends_with().

str_starts_with() and str_ends_with() were introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) begins or ends with the given substring (needle).

WordPress core includes a polyfill for these functions on PHP < 8.0 as of WordPress 5.9.

This commit uses str_starts_with() and str_ends_with() in core files where appropriate:

  • $needle === substr( $string, 0, $length ), where $length is the length of $needle, is replaced with str_starts_with( $haystack, $needle ).
  • $needle === substr( $string, $offset ), where $offset is negative and the absolute value of $offset is the length of $needle, is replaced with str_ends_with( $haystack, $needle ).

This aims to make the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [52039], [52040], [52326], [55703], [55710], [55987], [55988].

Props Soean, spacedmonkey, Clorith, ocean90, azaozz, sabernhardt, SergeyBiryukov.
Fixes #58220.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/pomo/po.php

    r55988 r55990  
    506506         */
    507507        public static function trim_quotes( $s ) {
    508             if ( '"' === substr( $s, 0, 1 ) ) {
     508            if ( str_starts_with( $s, '"' ) ) {
    509509                $s = substr( $s, 1 );
    510510            }
    511             if ( '"' === substr( $s, -1, 1 ) ) {
     511            if ( str_ends_with( $s, '"' ) ) {
    512512                $s = substr( $s, 0, -1 );
    513513            }
Note: See TracChangeset for help on using the changeset viewer.