Changeset 56004 for trunk/src/wp-admin/includes/class-wp-comments-list-table.php

Timestamp:

06/23/2023 05:47:34 PM (3 years ago)

Author:

joedolson

Message:

Administration: Backwards compatibility for new sortable keys.

Replace use of list to parse array keys into variables. list throws errors if the keys don't exist, and many extenders will not define the new array keys. The code path already falls back effectively for empty values.

Also add translator comments to screen reader hidden text, fix a docblock, and fix an HTML error.

Follow up to [r55971].

Props kebbet, chouby, joedolson.
Fixes #32170.

File:

• trunk/src/wp-admin/includes/class-wp-comments-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-comments-list-table.php

@@ -584 +584 @@
                 if ( ! isset( $_GET['orderby'] ) ) {
                         // In the initial view, Comments are ordered by comment's date but there's no column for that.
-                        echo '<caption class="screen-reader-text">' . __( 'Ordered by Comment Date, descending.' ) . '</p>';
+                        echo '<caption class="screen-reader-text">' .
+                        /* translators: Hidden accessibility text. */
+                        __( 'Ordered by Comment Date, descending.' ) .
+                        '</caption>';
                 } else {
                         $this->print_table_description();