Changeset 56016

Timestamp:

06/24/2023 01:38:44 PM (18 months ago)

Author:

SergeyBiryukov

Message:

General: Return early from str_ends_with() polyfill if both haystack and needle are empty.

Prior to PHP 7.0, substr( '', -0, 0 ) returns false instead of an empty string, so the strict comparison further in the function did not work as expected.

This commit addresses a test failure on PHP < 7.0, making the function consistently return true if both haystack and needle are an empty string.

Follow-up to [52040], [56014], [56015].

See #58220.

File:

• trunk/src/wp-includes/compat.php (modified) (1 diff)

trunk/src/wp-includes/compat.php

@@ -483 +483 @@
      */
     function str_ends_with( $haystack, $needle ) {
-        if ( '' === $haystack && '' !== $needle ) {
-            return false;
+        if ( '' === $haystack ) {
+            return '' === $needle;
         }