Changeset 56018

Timestamp:

06/24/2023 02:30:31 PM (15 months ago)

Author:

joedolson

Message:

Editor: Improve accessibility of new custom field UI.

Add labels; change Enter new/Cancel link to a button; move focus to input when creating new field; move Add Custom Field out of fields table.

Props jane, batmoo, karmatosed, franrosa, sabernhardt, annashopina, oglekler, joedolson.
Fixes #15631.

Location:

trunk/src

Files:

• js/_enqueues/lib/lists.js (modified) (1 diff)
• wp-admin/css/edit.css (modified) (2 diffs)
• wp-admin/includes/template.php (modified) (4 diffs)

trunk/src/js/_enqueues/lib/lists.js

@@ -748 +748 @@
         } );
 
-        $element.on( 'click', 'a[data-wp-lists^="add:' + list.id + ':"], input[data-wp-lists^="add:' + list.id + ':"]', function() {
+        $element.on( 'click', '[data-wp-lists^="add:' + list.id + ':"], input[data-wp-lists^="add:' + list.id + ':"]', function() {
             return list.wpList.add( this );
         } );

trunk/src/wp-admin/css/edit.css

@@ -1069 +1069 @@
 }
 
+#postcustom #postcustomstuff .add-custom-field {
+    padding: 12px 8px 8px;
+}
+
 #side-sortables #postcustom #postcustomstuff .submit {
     margin: 0;
@@ -1119 +1123 @@
 }
 
-#postcustomstuff #newmetaleft a {
+#postcustomstuff #newmetaleft a,
+#postcustomstuff #newmeta-button {
     display: inline-block;
     margin: 0 8px 8px;

trunk/src/wp-admin/includes/template.php

@@ -725 +725 @@
     if ( $keys ) {
         natcasesort( $keys );
-        $meta_key_input_id = 'metakeyselect';
-    } else {
-        $meta_key_input_id = 'metakeyinput';
     }
     ?>
@@ -734 +731 @@
 <thead>
 <tr>
-<th class="left"><label for="<?php echo $meta_key_input_id; ?>"><?php _ex( 'Name', 'meta name' ); ?></label></th>
+<th class="left"><label for="metakeyselect"><?php _ex( 'Name', 'meta name' ); ?></label></th>
 <th><label for="metavalue"><?php _e( 'Value' ); ?></label></th>
 </tr>
@@ -754 +751 @@
         ?>
 </select>
-<input class="hide-if-js" type="text" id="metakeyinput" name="metakeyinput" value="" />
-<a href="#postcustomstuff" class="hide-if-no-js" onclick="jQuery('#metakeyinput, #metakeyselect, #enternew, #cancelnew').toggle();return false;">
+<input class="hidden" type="text" id="metakeyinput" name="metakeyinput" value="" aria-label="<?php _e( 'New custom field name' ); ?>" />
+<button type="button" id="newmeta-button" class="button button-small hide-if-no-js" onclick="jQuery('#metakeyinput, #metakeyselect, #enternew, #cancelnew').toggleClass('hidden');jQuery('#metakeyinput, #metakeyselect').filter(':visible').trigger('focus');">
 <span id="enternew"><?php _e( 'Enter new' ); ?></span>
-<span id="cancelnew" class="hidden"><?php _e( 'Cancel' ); ?></span></a>
+<span id="cancelnew" class="hidden"><?php _e( 'Cancel' ); ?></span></button>
 <?php } else { ?>
 <input type="text" id="metakeyinput" name="metakeyinput" value="" />
 <?php } ?>
 </td>
-<td><textarea id="metavalue" name="metavalue" rows="2" cols="25"></textarea></td>
+<td><textarea id="metavalue" name="metavalue" rows="2" cols="25"></textarea>
+    <?php wp_nonce_field( 'add-meta', '_ajax_nonce-add-meta', false ); ?>
+</td>
 </tr>
-
-<tr><td colspan="2">
-<div class="submit">
+</tbody>
+</table>
+<div class="submit add-custom-field">
     <?php
     submit_button(
@@ -780 +779 @@
     ?>
 </div>
-    <?php wp_nonce_field( 'add-meta', '_ajax_nonce-add-meta', false ); ?>
-</td></tr>
-</tbody>
-</table>
     <?php
-
 }