Changeset 56022

Timestamp:

06/25/2023 03:18:12 PM (3 years ago)

Author:

joedolson

Message:

Quick/Bulk Edit: Don't set publish date when editing drafts.

Ensure that quick edit does not define a publish date if the post status is one of 'draft', 'pending', or 'auto-draft'.

Props uxtremist, SergeyBiryukov, Denis-de-Bernardy, jane, rfischmann, mista-flo, rutviksavsani, oglekler, joedolson.
Fixes #19907.

Location:

trunk

Files:

• src/js/_enqueues/admin/inline-edit-post.js (modified) (1 diff)
• src/wp-admin/includes/post.php (modified) (1 diff)
• tests/phpunit/tests/ajax/wpAjaxInlineSave.php (modified) (1 diff)

trunk/src/js/_enqueues/admin/inline-edit-post.js

@@ -450 +450 @@
 
                 fields = $('#edit-'+id).find(':input').serialize();
+
+                var status = $(':input[name="_status"]').val();
+
+                if ( [ 'draft', 'pending', 'auto-draft' ].includes( status ) ) {
+                        params.edit_date = 'false';
+                }
+
                 params = fields + '&' + $.param(params);
 

trunk/src/wp-admin/includes/post.php

@@ -168 +168 @@
                         break;
                 }
+        }
+
+        if ( isset( $post_data['edit_date'] ) && 'false' === $post_data['edit_date'] ) {
+                $post_data['edit_date'] = false;
         }
 

trunk/tests/phpunit/tests/ajax/wpAjaxInlineSave.php

@@ -88 +88 @@
                 $this->assertSameSets( array( $t2 ), wp_list_pluck( $post_terms_2, 'term_id' ) );
         }
+
+        /**
+         * When updating a draft in quick edit mode, it should not set the publish date of the post when this one will be published.
+         *
+         * @ticket 19907
+         *
+         * @covers ::edit_post
+         */
+        public function test_quick_edit_draft_should_not_set_publish_date() {
+                // Become an administrator.
+                $this->_setRole( 'administrator' );
+
+                $user = get_current_user_id();
+
+                $post = self::factory()->post->create_and_get(
+                        array(
+                                'post_status' => 'draft',
+                                'post_author' => $user,
+                        )
+                );
+
+                $this->assertSame( 'draft', $post->post_status );
+
+                $this->assertEquals( '0000-00-00 00:00:00', $post->post_date_gmt );
+
+                // Set up a request.
+                $_POST['_inline_edit'] = wp_create_nonce( 'inlineeditnonce' );
+                $_POST['post_ID']      = $post->ID;
+                $_POST['post_type']    = 'post';
+                $_POST['content']      = 'content test';
+                $_POST['excerpt']      = 'excerpt test';
+                $_POST['_status']      = $post->post_status;
+                $_POST['post_status']  = $post->post_status;
+                $_POST['post_author']  = $user;
+                $_POST['screen']       = 'edit-post';
+                $_POST['post_view']    = 'list';
+                $_POST['edit_date']    = 'false';
+                $_POST['mm']           = '09';
+                $_POST['jj']           = 11;
+                $_POST['aa']           = 2020;
+                $_POST['hh']           = 19;
+                $_POST['mn']           = 20;
+                $_POST['ss']           = 11;
+
+                // Make the request.
+                try {
+                        $this->_handleAjax( 'inline-save' );
+                } catch ( WPAjaxDieContinueException $e ) {
+                        unset( $e );
+                }
+
+                $post = get_post( $post->ID );
+
+                $this->assertEquals( '0000-00-00 00:00:00', $post->post_date_gmt );
+        }
 }