Make WordPress Core


Ignore:
Timestamp:
06/26/2023 10:15:04 AM (18 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Use str_contains() in a few more places.

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [55988], [56021].

See #58206.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/ajax-actions.php

    r55990 r56031  
    33203320
    33213321    $url = empty( $attachment['url'] ) ? '' : $attachment['url'];
    3322     $rel = ( strpos( $url, 'attachment_id' ) || get_attachment_link( $id ) == $url );
     3322    $rel = ( str_contains( $url, 'attachment_id' ) || get_attachment_link( $id ) === $url );
    33233323
    33243324    remove_filter( 'media_send_to_editor', 'image_media_send_to_editor' );
Note: See TracChangeset for help on using the changeset viewer.