Make WordPress Core

Changeset 56032


Ignore:
Timestamp:
06/26/2023 10:42:54 AM (12 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Use str_contains() in a few more places.

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [55988], [56021], [56031].

See #58206.

Location:
trunk/src/wp-includes
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/default-constants.php

    r54236 r56032  
    106106    if ( ! defined( 'SCRIPT_DEBUG' ) ) {
    107107        if ( ! empty( $wp_version ) ) {
    108             $develop_src = false !== strpos( $wp_version, '-src' );
     108            $develop_src = str_contains( $wp_version, '-src' );
    109109        } else {
    110110            $develop_src = false;
  • trunk/src/wp-includes/load.php

    r56031 r56032  
    15061506    $bytes = (int) $value;
    15071507
    1508     if ( false !== strpos( $value, 'g' ) ) {
     1508    if ( str_contains( $value, 'g' ) ) {
    15091509        $bytes *= GB_IN_BYTES;
    1510     } elseif ( false !== strpos( $value, 'm' ) ) {
     1510    } elseif ( str_contains( $value, 'm' ) ) {
    15111511        $bytes *= MB_IN_BYTES;
    1512     } elseif ( false !== strpos( $value, 'k' ) ) {
     1512    } elseif ( str_contains( $value, 'k' ) ) {
    15131513        $bytes *= KB_IN_BYTES;
    15141514    }
     
    17891789    if ( isset( $_SERVER['HTTP_ACCEPT'] ) ) {
    17901790        foreach ( $accepted as $type ) {
    1791             if ( false !== strpos( $_SERVER['HTTP_ACCEPT'], $type ) ) {
     1791            if ( str_contains( $_SERVER['HTTP_ACCEPT'], $type ) ) {
    17921792                return true;
    17931793            }
Note: See TracChangeset for help on using the changeset viewer.