Changeset 56044 for trunk/tests/phpunit/tests/blocks/register.php

Timestamp:

06/26/2023 09:15:21 PM (18 months ago)

Author:

spacedmonkey

Message:

Editor: Register core block styles in one place.

Register all core blocks in a new function called register_core_block_style_handles. This mirrors the function wp_default_styles where all core styles are registered in one place. This improves block registration performance, as it avoids expensive file lookups, like realpath in register_block_style_handle. The new function register_core_block_style_handles uses glob to get all css files in the blocks directory. This glob is cached in a transient to save lookups on subsequent requests. The function register_block_style_handle now checks to see if the style handle is already registered before trying to register it again.

Props mukesh27, westonruter, flixos90, joemcgill, spacedmonkey.
Fixes #58528.

File:

• trunk/tests/phpunit/tests/blocks/register.php (modified) (3 diffs)

trunk/tests/phpunit/tests/blocks/register.php

@@ -398 +398 @@
     public function test_handle_passed_register_block_style_handle() {
         $metadata = array(
+            'name'  => 'test-block',
             'style' => 'test-style-handle',
         );
@@ -407 +408 @@
     public function test_handles_passed_register_block_style_handles() {
         $metadata = array(
+            'name'  => 'test-block',
             'style' => array( 'test-style-handle', 'test-style-handle-2' ),
         );
@@ -522 +524 @@
         $this->assertSame( $expected_style_handle, $result );
         $this->assertFalse( wp_styles()->get_data( $expected_style_handle, 'rtl' ) );
+    }
+
+    /**
+     * @ticket 58528
+     *
+     * @covers ::register_block_style_handle
+     */
+    public function test_success_register_block_style_handle_exists() {
+        $expected_style_handle = 'block-theme-example-block-editor-style';
+        wp_register_style( $expected_style_handle, false );
+        switch_theme( 'block-theme' );
+
+        $metadata = array(
+            'file'        => wp_normalize_path( get_theme_file_path( 'blocks/example-block/block.json' ) ),
+            'name'        => 'block-theme/example-block',
+            'editorStyle' => 'file:./editor-style.css',
+        );
+        $result   = register_block_style_handle( $metadata, 'editorStyle' );
+
+        $this->assertSame( $expected_style_handle, $result );
     }