Changeset 56045

Timestamp:

06/26/2023 09:31:30 PM (21 months ago)

Author:

audrasjb

Message:

Twenty Twenty: Remove various unused function parameters and variables.

This removes the $n variable from TwentyTwenty_Walker_Page class start_el() function, removes an unused global and the last parameter from
twentytwenty_filter_wp_list_pages_item_classes() and twentytwenty_add_sub_toggles_to_main_menu().

Props upadalavipul, sabernhardt, mukesh27.
Fixes #57371.

Location:

trunk/src/wp-content/themes/twentytwenty

Files:

• classes/class-twentytwenty-walker-page.php (modified) (1 diff)
• inc/template-tags.php (modified) (6 diffs)

trunk/src/wp-content/themes/twentytwenty/classes/class-twentytwenty-walker-page.php

@@ -39 +39 @@
             if ( isset( $args['item_spacing'] ) && 'preserve' === $args['item_spacing'] ) {
                 $t = "\t";
-                $n = "\n";
             } else {
                 $t = '';
-                $n = '';
             }
             if ( $depth ) {

trunk/src/wp-content/themes/twentytwenty/inc/template-tags.php

@@ -241 +241 @@
  *
  * @since Twenty Twenty 1.0
- *
- * @global WP_Post $post Global post object.
  *
  * @param int    $post_id  The ID of the post.
@@ -332 +330 @@
         $has_meta = false;
 
-        global $post;
         $the_post = get_post( $post_id );
         setup_postdata( $the_post );
@@ -546 +543 @@
  * @param int      $depth        Depth of page, used for padding.
  * @param array    $args         An array of arguments.
- * @param int      $current_page ID of the current page.
  * @return array CSS class names.
  */
-function twentytwenty_filter_wp_list_pages_item_classes( $css_class, $page, $depth, $args, $current_page ) {
+function twentytwenty_filter_wp_list_pages_item_classes( $css_class, $page, $depth, $args ) {
 
     // Only apply to wp_list_pages() calls with match_menu_classes set to true.
@@ -572 +568 @@
 }
 
-add_filter( 'page_css_class', 'twentytwenty_filter_wp_list_pages_item_classes', 10, 5 );
+add_filter( 'page_css_class', 'twentytwenty_filter_wp_list_pages_item_classes', 10, 4 );
 
 /**
@@ -581 +577 @@
  * @param stdClass $args  An object of wp_nav_menu() arguments.
  * @param WP_Post  $item  Menu item data object.
- * @param int      $depth Depth of menu item. Used for padding.
  * @return stdClass An object of wp_nav_menu() arguments.
  */
-function twentytwenty_add_sub_toggles_to_main_menu( $args, $item, $depth ) {
+function twentytwenty_add_sub_toggles_to_main_menu( $args, $item ) {
 
     // Add sub menu toggles to the Expanded Menu with toggles.
@@ -623 +618 @@
 }
 
-add_filter( 'nav_menu_item_args', 'twentytwenty_add_sub_toggles_to_main_menu', 10, 3 );
+add_filter( 'nav_menu_item_args', 'twentytwenty_add_sub_toggles_to_main_menu', 10, 2 );
 
 /**