Changeset 56053

Timestamp:

06/27/2023 06:00:59 AM (3 years ago)

Author:

isabel_brison

Message:

Editor: fix post edit navigation link.

Adds a custom link for navigation post types.

Props get_dave, spacedmonkey, ramonopoly.
Fixes #58589.

Location:

trunk

Files:

• src/wp-includes/link-template.php (modified) (2 diffs)
• src/wp-includes/post.php (modified) (2 diffs)
• tests/phpunit/tests/link/getEditPostLink.php (modified) (1 diff)

trunk/src/wp-includes/link-template.php

@@ -1439 +1439 @@
  *
  * @since 2.3.0
+ * @since 6.3.0 Adds custom link for wp_navigation post types.
+ *              Adds custom links for wp_template_part and wp_template post types.
  *
  * @param int|WP_Post $post    Optional. Post ID or post object. Default is the global `$post`.
@@ -1475 +1477 @@
                 $slug = urlencode( get_stylesheet() . '//' . $post->post_name );
                 $link = admin_url( sprintf( $post_type_object->_edit_link, $post->post_type, $slug ) );
+        } elseif ( 'wp_navigation' === $post->post_type ) {
+                $link = admin_url( sprintf( $post_type_object->_edit_link, (string) $post->ID ) );
         } elseif ( $post_type_object->_edit_link ) {
                 $link = admin_url( sprintf( $post_type_object->_edit_link . $action, $post->ID ) );

trunk/src/wp-includes/post.php

@@ -492 +492 @@
         );
 
+        $navigation_post_edit_link = 'site-editor.php?' . build_query(
+                array(
+                        'postId'   => '%s',
+                        'postType' => 'wp_navigation',
+                        'canvas'   => 'edit',
+                )
+        );
+
         register_post_type(
                 'wp_navigation',
@@ -518 +526 @@
                         'public'                => false,
                         '_builtin'              => true, /* internal use only. don't use this when registering your own post type. */
+                        '_edit_link'            => $navigation_post_edit_link, /* internal use only. don't use this when registering your own post type. */
                         'has_archive'           => false,
                         'show_ui'               => true,

trunk/tests/phpunit/tests/link/getEditPostLink.php

@@ -132 +132 @@
                 $this->assertSame( $link_custom_context, get_edit_post_link( $template_part_post, 'something-else' ), 'Pass non-default value in second argument.' );
         }
+
+        /**
+         * Tests getting the edit post link for a wp_navigation post type.
+         *
+         * @ticket 58589
+         * */
+        public function test_get_edit_post_link_for_wp_navigation_post_type() {
+                $navigation_post = self::factory()->post->create_and_get(
+                        array(
+                                'post_type'    => 'wp_navigation',
+                                'post_name'    => 'my_navigation',
+                                'post_title'   => 'My Navigation',
+                                'post_content' => '<!-- wp:navigation-link {"label":"WordPress","type":"custom","url":"http://www.wordpress.org/","kind":"custom"} /-->',
+                                'post_excerpt' => 'Description of my Navigation',
+                        )
+                );
+
+                $post_type_object = get_post_type_object( $navigation_post->post_type );
+
+                $link_default_context = admin_url( sprintf( $post_type_object->_edit_link, $navigation_post->ID ) );
+                $link_custom_context  = admin_url( sprintf( $post_type_object->_edit_link, $navigation_post->ID ) );
+
+                $this->assertSame( $link_default_context, get_edit_post_link( $navigation_post ), 'Second argument `$context` has a default context of `"display"`.' );
+                $this->assertSame( $link_custom_context, get_edit_post_link( $navigation_post, 'something-else' ), 'Pass non-default value in second argument.' );
+        }
 }