Context Navigation

← Previous Changeset
Next Changeset →

Changeset 56062

Timestamp:

06/27/2023 10:43:32 AM (19 months ago)

Author:

audrasjb

Message:

Twenty Nineteen: Always set background color and foreground color together.

On the <body> element, as a best practice background color and text color should always be set together. This makes it easier to quickly understand the
underlying color scheme.

Follow-up to [55960], [55964].

Props sabernhardt, audrasjb, kebbet.
Fixes #45916.

Location:

trunk/src/wp-content/themes/twentynineteen

Files:

: 4 edited

sass/elements/_elements.scss (modified) (1 diff)
sass/typography/_typography.scss (modified) (1 diff)
style-rtl.css (modified) (2 diffs)
style.css (modified) (2 diffs)

Legend:

: Unmodified
: Added
: Removed

trunk/src/wp-content/themes/twentynineteen/sass/elements/_elements.scss

-                      r55964
+                      r56062
 *:after {
     box-sizing: inherit;
+}
-body {
-    background-color: $color__background-body;
+}

trunk/src/wp-content/themes/twentynineteen/sass/typography/_typography.scss

r55964	r56062
7	7	-webkit-font-smoothing: antialiased;
8	8	-moz-osx-font-smoothing: grayscale;
	9	background-color: $color__background-body;
9	10	color: $color__text-main;
10	11	@include font-family( $font__body );

trunk/src/wp-content/themes/twentynineteen/style-rtl.css

-                      r55964
+                      r56062
   -webkit-font-smoothing: antialiased;
   -moz-osx-font-smoothing: grayscale;
+  background-color: #fff;
   color: #111;
   font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
 …
 *:after {
   box-sizing: inherit;
+}
-body {
-  background-color: #fff;
+}

trunk/src/wp-content/themes/twentynineteen/style.css

-                      r55964
+                      r56062
   -webkit-font-smoothing: antialiased;
   -moz-osx-font-smoothing: grayscale;
+  background-color: #fff;
   color: #111;
   font-family: "NonBreakingSpaceOverride", "Hoefler Text", Garamond, "Times New Roman", serif;
 …
 *:after {
   box-sizing: inherit;
+}
-body {
-  background-color: #fff;
+}

Note: See TracChangeset for help on using the changeset viewer.

Trac UI Preferences

Make WordPress Core