Changeset 56066

Timestamp:

06/27/2023 02:33:39 PM (15 months ago)

Author:

spacedmonkey

Message:

Database: Move the if statement outside of the loop.

In the foreach loop of last results, move the if statement outside of the loop. There is no need to check every element in the array for the output type. Do this once outside of the loop. For large database queries with lots of rows returned, this should improve PHP performance.

Props spacedmonkey, Cybr, johnbillion, costdev, joemcgill.
Fixes #56541.

File:

• trunk/src/wp-includes/class-wpdb.php (modified) (1 diff)

trunk/src/wp-includes/class-wpdb.php

@@ -3138 +3138 @@
             // Return an integer-keyed array of...
             if ( $this->last_result ) {
-                foreach ( (array) $this->last_result as $row ) {
-                    if ( ARRAY_N === $output ) {
+                if ( ARRAY_N === $output ) {
+                    foreach ( (array) $this->last_result as $row ) {
                         // ...integer-keyed row arrays.
                         $new_array[] = array_values( get_object_vars( $row ) );
-                    } else {
+                    }
+                } else {
+                    foreach ( (array) $this->last_result as $row ) {
                         // ...column name-keyed row arrays.
                         $new_array[] = get_object_vars( $row );