Changeset 56072 for trunk/src/wp-admin/includes/class-wp-media-list-table.php

Timestamp:

06/27/2023 04:26:15 PM (15 months ago)

Author:

SergeyBiryukov

Message:

Media: Only show “Copy” and “Download” actions when an attachment URL is available.

Includes unit tests to verify the logic for displaying row actions in the Media Library in certain scenarios, e.g. with and without the “Trash” or “Unattached” filter.

Follow-up to [55949].

Props costdev, kebbet, mukesh27, oglekler.
Fixes #57893.

File:

• trunk/src/wp-admin/includes/class-wp-media-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-media-list-table.php

@@ -817 +817 @@
             }
 
-            $actions['copy'] = sprintf(
-                '<span class="copy-to-clipboard-container"><button type="button" class="button-link copy-attachment-url media-library" data-clipboard-text="%s" aria-label="%s">%s</button><span class="success hidden" aria-hidden="true">%s</span></span>',
+            if ( $attachment_url ) {
+                $actions['copy'] = sprintf(
+                    '<span class="copy-to-clipboard-container"><button type="button" class="button-link copy-attachment-url media-library" data-clipboard-text="%s" aria-label="%s">%s</button><span class="success hidden" aria-hidden="true">%s</span></span>',
+                    esc_url( $attachment_url ),
+                    /* translators: %s: Attachment title. */
+                    esc_attr( sprintf( __( 'Copy &#8220;%s&#8221; URL to clipboard' ), $att_title ) ),
+                    __( 'Copy URL' ),
+                    __( 'Copied!' )
+                );
+            }
+        }
+
+        if ( $attachment_url ) {
+            $actions['download'] = sprintf(
+                '<a href="%s" aria-label="%s" download>%s</a>',
                 esc_url( $attachment_url ),
                 /* translators: %s: Attachment title. */
-                esc_attr( sprintf( __( 'Copy &#8220;%s&#8221; URL to clipboard' ), $att_title ) ),
-                __( 'Copy URL' ),
-                __( 'Copied!' )
+                esc_attr( sprintf( __( 'Download &#8220;%s&#8221;' ), $att_title ) ),
+                __( 'Download file' )
             );
         }
-
-        $actions['download'] = sprintf(
-            '<a href="%s" aria-label="%s" download>%s</a>',
-            esc_url( $attachment_url ),
-            /* translators: %s: Attachment title. */
-            esc_attr( sprintf( __( 'Download &#8220;%s&#8221;' ), $att_title ) ),
-            __( 'Download file' )
-        );
 
         if ( $this->detached && current_user_can( 'edit_post', $post->ID ) ) {