Changeset 56092 for trunk/src/wp-includes/class-wp-scripts.php

Timestamp:

06/28/2023 02:14:58 PM (22 months ago)

Author:

azaozz

Message:

Script Loader: Fix unintended adding of async to scripts that are printed directly with wp_print_scripts() without enqueueing them beforehand.

Props: joemcgill, westonruter, felixarntz, peterwilsoncc.
See: #58648.

File:

• trunk/src/wp-includes/class-wp-scripts.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-scripts.php

@@ -908 +908 @@
      */
     private function get_eligible_loading_strategy( $handle ) {
-        $eligible = $this->filter_eligible_strategies( $handle );
-
-        // Bail early once we know the eligible strategy is blocking.
+        $intended = (string) $this->get_data( $handle, 'strategy' );
+
+        // Bail early if there is no intended strategy.
+        if ( ! $intended ) {
+            return '';
+        }
+
+        // If the intended strategy is 'defer', limit the initial list of eligibles.
+        $initial = ( 'defer' === $intended ) ? array( 'defer' ) : null;
+
+        $eligible = $this->filter_eligible_strategies( $handle, $initial );
+
+        // Return early once we know the eligible strategy is blocking.
         if ( empty( $eligible ) ) {
             return '';