Changeset 56093

Timestamp:

06/28/2023 03:51:23 PM (10 months ago)

Author:

kadamwhite

Message:

REST API: Cache schema in block pattern and menu item endpoints.

Performance improvement to add schema caching to pattern and menu item REST endpoints, so identical schema object are not needlessly regenerated.

Props spacedmonkey.
Fixes #58657. See [45811].

Location:

trunk/src/wp-includes/rest-api/endpoints

Files:

• class-wp-rest-block-pattern-categories-controller.php (modified) (2 diffs)
• class-wp-rest-block-patterns-controller.php (modified) (2 diffs)
• class-wp-rest-blocks-controller.php (modified) (2 diffs)
• class-wp-rest-menu-items-controller.php (modified) (2 diffs)
• class-wp-rest-menus-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-block-pattern-categories-controller.php

@@ -126 +126 @@
      */
     public function get_item_schema() {
+        if ( $this->schema ) {
+            return $this->add_additional_fields_schema( $this->schema );
+        }
+
         $schema = array(
             '$schema'    => 'http://json-schema.org/draft-04/schema#',
@@ -152 +156 @@
         );
 
-        return $this->add_additional_fields_schema( $schema );
+        $this->schema = $schema;
+
+        return $this->add_additional_fields_schema( $this->schema );
     }
 }

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-block-patterns-controller.php

@@ -200 +200 @@
      */
     public function get_item_schema() {
+        if ( $this->schema ) {
+            return $this->add_additional_fields_schema( $this->schema );
+        }
+
         $schema = array(
             '$schema'    => 'http://json-schema.org/draft-04/schema#',
@@ -288 +292 @@
         );
 
-        return $this->add_additional_fields_schema( $schema );
+        $this->schema = $schema;
+
+        return $this->add_additional_fields_schema( $this->schema );
     }
 }

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-blocks-controller.php

@@ -68 +68 @@
      */
     public function get_item_schema() {
+        if ( $this->schema ) {
+            return $this->add_additional_fields_schema( $this->schema );
+        }
+
         // Do not cache this schema because all properties are derived from parent controller.
         $schema = parent::get_item_schema();
@@ -87 +91 @@
         unset( $schema['properties']['content']['properties']['rendered'] );
 
-        return $schema;
+        $this->schema = $schema;
+
+        return $this->add_additional_fields_schema( $this->schema );
     }
 

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-menu-items-controller.php

@@ -711 +711 @@
      */
     public function get_item_schema() {
+        if ( $this->schema ) {
+            return $this->add_additional_fields_schema( $this->schema );
+        }
+
         $schema = array(
             '$schema' => 'http://json-schema.org/draft-04/schema#',
@@ -915 +919 @@
         }
 
-        return $this->add_additional_fields_schema( $schema );
+        $this->schema = $schema;
+
+        return $this->add_additional_fields_schema( $this->schema );
     }
 

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-menus-controller.php

@@ -524 +524 @@
      */
     public function get_item_schema() {
+        if ( $this->schema ) {
+            return $this->add_additional_fields_schema( $this->schema );
+        }
+
         $schema = parent::get_item_schema();
         unset( $schema['properties']['count'], $schema['properties']['link'], $schema['properties']['taxonomy'] );
@@ -567 +571 @@
         );
 
-        return $schema;
+        $this->schema = $schema;
+
+        return $this->add_additional_fields_schema( $this->schema );
     }
 }