Changeset 56138

Timestamp:

07/05/2023 11:13:26 AM (21 months ago)

Author:

SergeyBiryukov

Message:

General: Revert strict comparison in WP_List_Util for now.

Casting the values to a string causes Array to string conversion PHP warnings, so using loose comparison restores the previous behavior for code relying on type juggling when using the wp_list_filter() function, e.g. comparing a numeric string to an integer.

The unit test case added for this scenario in the previous commit remains.

Follow-up to [55908], [56137].

See #57839.

File:

• trunk/src/wp-includes/class-wp-list-util.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-list-util.php

@@ -117 +117 @@
                 if ( is_array( $obj ) ) {
                     // Treat object as an array.
-                    if ( array_key_exists( $m_key, $obj )
-                        && ( (string) $m_value === (string) $obj[ $m_key ] )
-                    ) {
+                    if ( array_key_exists( $m_key, $obj ) && ( $m_value == $obj[ $m_key ] ) ) {
                         $matched++;
                     }
                 } elseif ( is_object( $obj ) ) {
                     // Treat object as an object.
-                    if ( isset( $obj->{$m_key} )
-                        && ( (string) $m_value === (string) $obj->{$m_key} )
-                    ) {
+                    if ( isset( $obj->{$m_key} ) && ( $m_value == $obj->{$m_key} ) ) {
                         $matched++;
                     }
@@ -281 +277 @@
             }
 
-            if ( (string) $a[ $field ] === (string) $b[ $field ] ) {
+            if ( $a[ $field ] == $b[ $field ] ) {
                 continue;
             }