Changeset 56142 for trunk/src/wp-includes/theme.php

Timestamp:

07/05/2023 07:28:02 PM (3 years ago)

Author:

flixos90

Message:

Media: Ensure custom header image tag supports loading optimization attributes.

This changeset is a follow up to [56037] and ensures that the get_header_image_tag() function receives the benefits of wp_get_loading_optimization_attributes() as well. Prior to fetchpriority support, this was not needed since the header image should never be lazy-loaded, but the image certainly is a fetchpriority candidate, so therefore it is crucial to have it supported.

Props felipeelia, spacedmonkey, mukesh27, westonruter, flixos90.
Fixes #58680.

File:

• trunk/src/wp-includes/theme.php (modified) (2 diffs)

trunk/src/wp-includes/theme.php

@@ -1238 +1238 @@
                 $attr,
                 array(
-                        'src'    => $header->url,
-                        'width'  => $width,
-                        'height' => $height,
-                        'alt'    => $alt,
+                        'src'      => $header->url,
+                        'width'    => $width,
+                        'height'   => $height,
+                        'alt'      => $alt,
+                        'decoding' => 'async',
                 )
         );
@@ -1264 +1265 @@
                         }
                 }
+        }
+
+        $attr = array_merge(
+                $attr,
+                wp_get_loading_optimization_attributes( 'img', $attr, 'get_header_image_tag' )
+        );
+
+        /*
+         * If the default value of `lazy` for the `loading` attribute is overridden
+         * to omit the attribute for this image, ensure it is not included.
+         */
+        if ( isset( $attr['loading'] ) && ! $attr['loading'] ) {
+                unset( $attr['loading'] );
+        }
+
+        // If the `fetchpriority` attribute is overridden and set to false or an empty string.
+        if ( isset( $attr['fetchpriority'] ) && ! $attr['fetchpriority'] ) {
+                unset( $attr['fetchpriority'] );
+        }
+
+        // If the `decoding` attribute is overridden and set to false or an empty string.
+        if ( isset( $attr['decoding'] ) && ! $attr['decoding'] ) {
+                unset( $attr['decoding'] );
         }