WordPress.org
Get WordPress

Make WordPress Core

Changeset 56211


Ignore:
Timestamp:
07/11/2023 12:57:19 PM (3 years ago)
Author:
audrasjb
Message:

I18n: Improve the use of dashicons-external icon for external links.

This changeset modifies how the dashicons-external icon is used in external links by editing its styles and adding a space between the text and the icon
for better accessibility.

Props SergeyBiryukov, afercia, isabel_brison, mukesh27, sabernhardt, oglekler, audrasjb.
Fixes #47303.

Location:
trunk/src
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/wp-admin/css/common.css

    r56187 r56211  
    137137.button .screen-reader-text {
    138138        height: auto; /* Fixes a Safari+VoiceOver bug, see ticket #42006 */
     139}
     140
     141.screen-reader-text + .dashicons-external {
     142        margin-top: -1px;
     143        margin-left: 2px;
    139144}
    140145

  • trunk/src/wp-admin/includes/class-wp-site-health.php

    r56174 r56211  
    747747                        ),
    748748                        'actions'     => sprintf(
    749                                 '<p><a href="%s" target="_blank" rel="noopener">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
     749                                '<p><a href="%s" target="_blank" rel="noopener">%s<span class="screen-reader-text"> %s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
    750750                                esc_url( wp_get_update_php_url() ),
    751751                                __( 'Learn more about updating PHP' ),
    … …  
    895895                                        'target="_blank" rel="noopener"',
    896896                                        sprintf(
    897                                                 ' <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span>',
     897                                                '<span class="screen-reader-text"> %s</span><span aria-hidden="true" class="dashicons dashicons-external"></span>',
    898898                                                /* translators: Hidden accessibility text. */
    899899                                                __( '(opens in a new tab)' )
    … …  
    12191219                        ),
    12201220                        'actions'     => sprintf(
    1221                                 '<p><a href="%s" target="_blank" rel="noopener">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
     1221                                '<p><a href="%s" target="_blank" rel="noopener">%s<span class="screen-reader-text"> %s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
    12221222                                /* translators: Localized version of WordPress requirements if one exists. */
    12231223                                esc_url( __( 'https://wordpress.org/about/requirements/' ) ),
    … …  
    14591459
    14601460                        $result['actions'] = sprintf(
    1461                                 '<p><a href="%s" target="_blank" rel="noopener">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
     1461                                '<p><a href="%s" target="_blank" rel="noopener">%s<span class="screen-reader-text"> %s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
    14621462                                /* translators: Localized Support reference. */
    14631463                                esc_url( __( 'https://wordpress.org/support/forums/' ) ),
    … …  
    14971497                        ),
    14981498                        'actions'     => sprintf(
    1499                                 '<p><a href="%s" target="_blank" rel="noopener">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
     1499                                '<p><a href="%s" target="_blank" rel="noopener">%s<span class="screen-reader-text"> %s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
    15001500                                /* translators: Documentation explaining debugging in WordPress. */
    15011501                                esc_url( __( 'https://wordpress.org/documentation/article/debugging-in-wordpress/' ) ),
    … …  
    24792479                } else {
    24802480                        $result['actions'] .= sprintf(
    2481                                 '<p><a href="%s" target="_blank" rel="noopener">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
     2481                                '<p><a href="%s" target="_blank" rel="noopener">%s<span class="screen-reader-text"> %s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
    24822482                                __( 'https://developer.wordpress.org/rest-api/frequently-asked-questions/#why-is-authentication-not-working' ),
    24832483                                __( 'Learn how to configure the Authorization header.' ),
    … …  
    25122512                        'label'       => '',
    25132513                        'actions'     => sprintf(
    2514                                 '<p><a href="%1$s" target="_blank" rel="noopener noreferrer">%2$s <span class="screen-reader-text">%3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
     2514                                '<p><a href="%1$s" target="_blank" rel="noopener noreferrer">%2$s<span class="screen-reader-text"> %3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
    25152515                                __( 'https://wordpress.org/documentation/article/optimization/#Caching' ),
    25162516                                __( 'Learn more about page cache' ),
    … …  
    26382638                        ),
    26392639                        'actions'     => sprintf(
    2640                                 '<p><a href="%s" target="_blank" rel="noopener">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
     2640                                '<p><a href="%s" target="_blank" rel="noopener">%s<span class="screen-reader-text"> %s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
    26412641                                esc_url( $action_url ),
    26422642                                __( 'Learn more about persistent object caching.' ),

  • trunk/src/wp-admin/includes/dashboard.php

    r55916 r56211  
    12991299                <?php
    13001300                        printf(
    1301                                 '<a href="%1$s" target="_blank">%2$s <span class="screen-reader-text">%3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a>',
     1301                                '<a href="%1$s" target="_blank">%2$s <span class="screen-reader-text"> %3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a>',
    13021302                                'https://make.wordpress.org/community/meetups-landing-page',
    13031303                                __( 'Meetups' ),
    … …  
    13111311                <?php
    13121312                        printf(
    1313                                 '<a href="%1$s" target="_blank">%2$s <span class="screen-reader-text">%3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a>',
     1313                                '<a href="%1$s" target="_blank">%2$s <span class="screen-reader-text"> %3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a>',
    13141314                                'https://central.wordcamp.org/schedule/',
    13151315                                __( 'WordCamps' ),
    … …  
    13231323                <?php
    13241324                        printf(
    1325                                 '<a href="%1$s" target="_blank">%2$s <span class="screen-reader-text">%3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a>',
     1325                                '<a href="%1$s" target="_blank">%2$s <span class="screen-reader-text"> %3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a>',
    13261326                                /* translators: If a Rosetta site exists (e.g. https://es.wordpress.org/news/), then use that. Otherwise, leave untranslated. */
    13271327                                esc_url( _x( 'https://wordpress.org/news/', 'Events and News dashboard widget' ) ),
    … …  
    16491649                        );
    16501650                        printf(
    1651                                 '<a href="%1$s">%2$s <span class="screen-reader-text">(%3$s)</span></a>',
     1651                                '<a href="%1$s">%2$s<span class="screen-reader-text"> (%3$s)</span></a>',
    16521652                                esc_url( admin_url( 'upload.php' ) ),
    16531653                                $text,
    … …  
    16651665                        );
    16661666                        printf(
    1667                                 '<a href="%1$s" class="musublink">%2$s <span class="screen-reader-text">(%3$s)</span></a>',
     1667                                '<a href="%1$s" class="musublink">%2$s<span class="screen-reader-text"> (%3$s)</span></a>',
    16681668                                esc_url( admin_url( 'upload.php' ) ),
    16691669                                $text,
    … …  
    18961896                <?php
    18971897                printf(
    1898                         '<a class="button button-primary" href="%1$s" target="_blank" rel="noopener">%2$s <span class="screen-reader-text">%3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a>',
     1898                        '<a class="button button-primary" href="%1$s" target="_blank" rel="noopener">%2$s<span class="screen-reader-text"> %3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a>',
    18991899                        esc_url( wp_get_update_php_url() ),
    19001900                        __( 'Learn more about updating PHP' ),

  • trunk/src/wp-includes/functions.php

    r56191 r56211  
    82408240        echo '<p class="button-container">';
    82418241        printf(
    8242                 '<a class="button button-primary" href="%1$s" target="_blank" rel="noopener">%2$s <span class="screen-reader-text">%3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a>',
     8242                '<a class="button button-primary" href="%1$s" target="_blank" rel="noopener">%2$s<span class="screen-reader-text"> %3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a>',
    82438243                esc_url( $direct_update_url ),
    82448244                __( 'Update PHP' ),
Note: See TracChangeset for help on using the changeset viewer.