Context Navigation

← Previous Change
Next Change →

class-wp-site-health.php

Timestamp:

07/11/2023 12:57:19 PM (3 years ago)

Author:

audrasjb

Message:

I18n: Improve the use of dashicons-external icon for external links.

This changeset modifies how the dashicons-external icon is used in external links by editing its styles and adding a space between the text and the icon
for better accessibility.

Props SergeyBiryukov, afercia, isabel_brison, mukesh27, sabernhardt, oglekler, audrasjb.
Fixes #47303.

File:

: 1 edited

trunk/src/wp-admin/includes/class-wp-site-health.php (modified) (8 diffs)

Legend:

: Unmodified
: Added
: Removed

trunk/src/wp-admin/includes/class-wp-site-health.php

-              r56174
+              r56211
                         ),
                         'actions'     => sprintf(
                                 '<p><a href="%s" target="_blank" rel="noopener">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
+                                '<p><a href="%s" target="_blank" rel="noopener">%s<span class="screen-reader-text"> %s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
                                 esc_url( wp_get_update_php_url() ),
                                 __( 'Learn more about updating PHP' ),
 …
                                         'target="_blank" rel="noopener"',
                                         sprintf(
                                                 ' <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span>',
+                                                '<span class="screen-reader-text"> %s</span><span aria-hidden="true" class="dashicons dashicons-external"></span>',
                                                 /* translators: Hidden accessibility text. */
                                                 __( '(opens in a new tab)' )
 …
                         ),
                         'actions'     => sprintf(
                                 '<p><a href="%s" target="_blank" rel="noopener">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
+                                '<p><a href="%s" target="_blank" rel="noopener">%s<span class="screen-reader-text"> %s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
                                 /* translators: Localized version of WordPress requirements if one exists. */
                                 esc_url( __( 'https://wordpress.org/about/requirements/' ) ),
 …
                         $result['actions'] = sprintf(
                                 '<p><a href="%s" target="_blank" rel="noopener">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
+                                '<p><a href="%s" target="_blank" rel="noopener">%s<span class="screen-reader-text"> %s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
                                 /* translators: Localized Support reference. */
                                 esc_url( __( 'https://wordpress.org/support/forums/' ) ),
 …
                         ),
                         'actions'     => sprintf(
                                 '<p><a href="%s" target="_blank" rel="noopener">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
+                                '<p><a href="%s" target="_blank" rel="noopener">%s<span class="screen-reader-text"> %s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
                                 /* translators: Documentation explaining debugging in WordPress. */
                                 esc_url( __( 'https://wordpress.org/documentation/article/debugging-in-wordpress/' ) ),
 …
                 } else {
                         $result['actions'] .= sprintf(
                                 '<p><a href="%s" target="_blank" rel="noopener">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
+                                '<p><a href="%s" target="_blank" rel="noopener">%s<span class="screen-reader-text"> %s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
                                 __( 'https://developer.wordpress.org/rest-api/frequently-asked-questions/#why-is-authentication-not-working' ),
                                 __( 'Learn how to configure the Authorization header.' ),
 …
                         'label'       => '',
                         'actions'     => sprintf(
                                 '<p><a href="%1$s" target="_blank" rel="noopener noreferrer">%2$s <span class="screen-reader-text">%3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
+                                '<p><a href="%1$s" target="_blank" rel="noopener noreferrer">%2$s<span class="screen-reader-text"> %3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
                                 __( 'https://wordpress.org/documentation/article/optimization/#Caching' ),
                                 __( 'Learn more about page cache' ),
 …
                         ),
                         'actions'     => sprintf(
                                 '<p><a href="%s" target="_blank" rel="noopener">%s <span class="screen-reader-text">%s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
+                                '<p><a href="%s" target="_blank" rel="noopener">%s<span class="screen-reader-text"> %s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
                                 esc_url( $action_url ),
                                 __( 'Learn more about persistent object caching.' ),

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 56211 for trunk/src/wp-admin/includes/class-wp-site-health.php

Legend:

trunk/src/wp-admin/includes/class-wp-site-health.php

Download in other formats: