Changeset 56214 for trunk/src/wp-includes/media.php

Timestamp:

07/11/2023 01:56:55 PM (14 months ago)

Author:

joemcgill

Message:

Media: Optimize images created in shortcodes.

This fixes an issue where images dynamically created during shortcode rendering (e.g., shortcode image galleries), were not getting image optimizations like loading="lazy" or fetchpriority="hight" applied. Note that even after this commit, shortcodes are processed after the main content images, which can affect the order in which optimizations are applied in content areas.

Follow-up to [56037].

Props spacedmonkey, flixos90, thekt12, swissspidy, joemcgill.
Fixes #58681.

File:

• trunk/src/wp-includes/media.php (modified) (1 diff)

trunk/src/wp-includes/media.php

@@ -5726 +5726 @@
     /*
      * The first elements in 'the_content' or 'the_post_thumbnail' should not be lazy-loaded,
-     * as they are likely above the fold.
-     */
-    if ( 'the_content' === $context || 'the_post_thumbnail' === $context ) {
+     * as they are likely above the fold. Shortcodes are processed after content images, so if
+     * thresholds haven't already been met, apply the same logic to those as well.
+     */
+    if ( 'the_content' === $context || 'the_post_thumbnail' === $context || 'do_shortcode' === $context ) {
         // Only elements within the main query loop have special handling.
         if ( is_admin() || ! in_the_loop() || ! is_main_query() ) {