Changeset 56243

Timestamp:

07/16/2023 04:43:07 PM (17 months ago)

Author:

joedolson

Message:

Help/About: Fix closing contextual help when scrolled.

Change from scrollIntoView to scrollIntoViewIfNeeded so scrolling will only fire when it is required. scrollIntoViewIfNeeded is a proprietary method that is not standardized and not currently on a track towards standards. However, testing has it working well, including in Firefox, which supposedly does not support it.

Props mikecho, studionashvegas, mai21, piotrek, Heiko_Mamerow, costdev, joedolson.
Fixes #55342.

File:

• trunk/src/js/_enqueues/admin/common.js (modified) (1 diff)

trunk/src/js/_enqueues/admin/common.js

@@ -1408 +1408 @@
      */
     $('#contextual-help-link, #show-settings-link').on( 'focus.scroll-into-view', function(e){
-        if ( e.target.scrollIntoView )
-            e.target.scrollIntoView(false);
+        if ( e.target.scrollIntoViewIfNeeded )
+            e.target.scrollIntoViewIfNeeded(false);
     });