Make WordPress Core


Ignore:
Timestamp:
07/17/2023 01:16:14 PM (11 months ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Use str_contains() in a few more places.

str_contains() was introduced in PHP 8.0 to perform a case-sensitive check indicating if the string to search in (haystack) contains the given substring (needle).

WordPress core includes a polyfill for str_contains() on PHP < 8.0 as of WordPress 5.9.

This commit replaces false !== strpos( ... ) with str_contains() in core files, making the code more readable and consistent, as well as better aligned with modern development practices.

Follow-up to [55988], [55990], [56014], [56021], [56031], [56032], [56065], [56241].

See #58206.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-login.php

    r56157 r56245  
    13631363            } elseif ( isset( $_GET['registration'] ) && 'disabled' === $_GET['registration'] ) {
    13641364                $errors->add( 'registerdisabled', __( '<strong>Error:</strong> User registration is currently not allowed.' ) );
    1365             } elseif ( strpos( $redirect_to, 'about.php?updated' ) ) {
     1365            } elseif ( str_contains( $redirect_to, 'about.php?updated' ) ) {
    13661366                $errors->add( 'updated', __( '<strong>You have successfully updated WordPress!</strong> Please log back in to see what&#8217;s new.' ), 'message' );
    13671367            } elseif ( WP_Recovery_Mode_Link_Service::LOGIN_ACTION_ENTERED === $action ) {
Note: See TracChangeset for help on using the changeset viewer.