Changeset 56247

Timestamp:

07/17/2023 02:05:51 PM (14 months ago)

Author:

kadamwhite

Message:

Build Tools: Remove outmoded jsvalidate task from Gruntfile.

grunt-jsvalidate was added to catch situations where minification introduced parsing errors in Internet Explorer.
IE is no longer supported by WordPress, and the grunt task itself has not been maintained for a decade.
Removing this task simplifies the build and avoids false-positive warnings where the outdated tool flags modern JS syntax incorrectly.

Props westonruter, joemcgill, jorbin, youknowriad, desrosj, swissspidy.
Fixes #58645. See #26615.

Location:

trunk

Files:

• Gruntfile.js (modified) (6 diffs)
• package-lock.json (modified) (1 diff)
• package.json (modified) (1 diff)

trunk/Gruntfile.js

@@ -1037 +1037 @@
             }
         },
-        jsvalidate:{
-            options: {
-                globals: {},
-                esprimaOptions:{},
-                verbose: false
-            },
-            build: {
-                files: {
-                    src: [
-                        WORKING_DIR + 'wp-{admin,includes}/**/*.js',
-                        WORKING_DIR + 'wp-content/themes/twenty*/**/*.js',
-                        '!' + WORKING_DIR + 'wp-content/themes/twenty*/node_modules/**/*.js',
-                        '!' + WORKING_DIR + 'wp-includes/blocks/**/*.js',
-                        '!' + WORKING_DIR + 'wp-includes/js/dist/**/*.js',
-                    ]
-                }
-            },
-            dynamic: {
-                files: {
-                    src: []
-                }
-            }
-        },
         imagemin: {
             core: {
@@ -1192 +1169 @@
             'js-enqueues': {
                 files: [SOURCE_DIR + 'js/_enqueues/**/*.js'],
-                tasks: ['clean:dynamic', 'copy:dynamic-js', 'uglify:dynamic', 'jsvalidate:dynamic'],
+                tasks: ['clean:dynamic', 'copy:dynamic-js', 'uglify:dynamic'],
                 options: {
                     dot: true,
@@ -1204 +1181 @@
                     'webpack-dev.config.js'
                 ],
-                tasks: ['clean:dynamic', 'webpack:dev', 'uglify:dynamic', 'jsvalidate:dynamic'],
+                tasks: ['clean:dynamic', 'webpack:dev', 'uglify:dynamic'],
                 options: {
                     dot: true,
@@ -1505 +1482 @@
         'uglify:all',
         'concat:tinymce',
-        'concat:emoji',
-        'jsvalidate:build'
+        'concat:emoji'
     ] );
 
@@ -1843 +1819 @@
                 grunt.config( [ 'copy', 'dynamic-js', 'files' ], files );
             }
-        // For the webpack builds configure the jsvalidate task to only check those files build by webpack.
+        // For the webpack builds configure the task to only check those files built by webpack.
         } else if ( target === 'js-webpack' ) {
             src = [
@@ -1871 +1847 @@
             if ( target === 'js-enqueues' ) {
                 grunt.config( [ 'uglify', 'dynamic', 'src' ], src );
-                grunt.config( [ 'jsvalidate', 'dynamic', 'files', 'src' ], src.map( function( dir ) { return  WORKING_DIR + dir; } ) );
+                grunt.config( [ 'dynamic', 'files', 'src' ], src.map( function( dir ) { return  WORKING_DIR + dir; } ) );
             }
             // For webpack only validate the file, minification is handled by webpack itself.
             if ( target === 'js-webpack' ) {
-                grunt.config( [ 'jsvalidate', 'dynamic', 'files', 'src' ], src.map( function( dir ) { return  WORKING_DIR + dir; } ) );
+                grunt.config( [ 'dynamic', 'files', 'src' ], src.map( function( dir ) { return  WORKING_DIR + dir; } ) );
             }
             // For css run the rtl task on just the changed file.

trunk/package-lock.json

@@ -13904 +13904 @@
             }
         },
-        "grunt-jsvalidate": {
-            "version": "0.2.2",
-            "resolved": "https://registry.npmjs.org/grunt-jsvalidate/-/grunt-jsvalidate-0.2.2.tgz",
-            "integrity": "sha512-FWpPrwspDVc0oZmnraBrLm5yx81gXroTLO4sYZd0iCMXxki/9TzKKhx30iOzTpAUGtUM7Q4rym+Y00MMmijBYQ==",
-            "dev": true,
-            "requires": {
-                "esprima": "~1.0.0"
-            },
-            "dependencies": {
-                "esprima": {
-                    "version": "1.0.4",
-                    "resolved": "https://registry.npmjs.org/esprima/-/esprima-1.0.4.tgz",
-                    "integrity": "sha512-rp5dMKN8zEs9dfi9g0X1ClLmV//WRyk/R15mppFNICIFRG5P92VP7Z04p8pk++gABo9W2tY+kHyu6P1mEHgmTA==",
-                    "dev": true
-                }
-            }
-        },
         "grunt-known-options": {
             "version": "2.0.0",

trunk/package.json

@@ -51 +51 @@
         "grunt-file-append": "0.0.7",
         "grunt-jsdoc": "2.4.1",
-        "grunt-jsvalidate": "~0.2.2",
         "grunt-legacy-util": "^2.0.1",
         "grunt-patch-wordpress": "~3.0.0",