Changeset 56252

Timestamp:

07/17/2023 10:01:08 PM (15 months ago)

Author:

audrasjb

Message:

External Libraries: Update deprecated jQuery code in Farbtastic lib.

This changeset updates some deprecated jQuery code in the Farbtastic external library. As this vendor script is not maintained anymore, this changeset
also adds a docblock to specify that the library has been "adopted" by WP Core.

Props Malae, sabernhardt, SergeyBiryukov, Presskopp, mrinal013, peterwilsoncc, oglekler, jorbin.
Fixes #57946.

File:

• trunk/src/js/_enqueues/vendor/farbtastic.js (modified) (6 diffs)

trunk/src/js/_enqueues/vendor/farbtastic.js

@@ -1 +1 @@
 /*!
  * Farbtastic: jQuery color picker plug-in v1.3u
+ * https://github.com/mattfarina/farbtastic
  *
  * Licensed under the GPL license:
  *   http://www.gnu.org/licenses/gpl.html
  */
+/**
+ * Modified for WordPress: replaced deprecated jQuery methods.
+ * See https://core.trac.wordpress.org/ticket/57946.
+ */
+
 (function($) {
 
@@ -50 +56 @@
     // Unbind previous nodes
     if (typeof fb.callback == 'object') {
-      $(fb.callback).unbind('keyup', fb.updateValue);
+      $(fb.callback).off('keyup', fb.updateValue);
     }
 
@@ -62 +68 @@
     else if (typeof callback == 'object' || typeof callback == 'string') {
       fb.callback = $(callback);
-      fb.callback.bind('keyup', fb.updateValue);
+      fb.callback.on('keyup', fb.updateValue);
       if (fb.callback.get(0).value) {
         fb.setColor(fb.callback.get(0).value);
@@ -117 +123 @@
     // Capture mouse
     if (!document.dragging) {
-      $(document).bind('mousemove', fb.mousemove).bind('mouseup', fb.mouseup);
+      $(document).on('mousemove', fb.mousemove).on('mouseup', fb.mouseup);
       document.dragging = true;
     }
@@ -156 +162 @@
   fb.mouseup = function () {
     // Uncapture mouse
-    $(document).unbind('mousemove', fb.mousemove);
-    $(document).unbind('mouseup', fb.mouseup);
+    $(document).off('mousemove', fb.mousemove);
+    $(document).off('mouseup', fb.mouseup);
     document.dragging = false;
   };
@@ -263 +269 @@
 
   // Install mousedown handler (the others are set on the document on-demand)
-  $('*', e).mousedown(fb.mousedown);
+  $('*', e).on('mousedown', fb.mousedown);
 
     // Init color