Changeset 56260

Timestamp:

07/18/2023 02:03:57 PM (20 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison for static strings in wp-admin/includes/class-wp-list-table.php.

Follow-up to [55971], [56004].

See #32170, #57839.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (8 diffs)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -1116 +1116 @@
      * In the second format, passing true as second parameter will make the initial
      * sorting order be descending. Following parameters add a short column name to
-     * be used as 'abbr' attribute, a translatable string for the current sorting
+     * be used as 'abbr' attribute, a translatable string for the current sorting,
      * and the initial order for the initial sorted column, 'asc' or 'desc' (default: false).
      *
@@ -1326 +1326 @@
 
         // Not in the initial view and descending order.
-        if ( isset( $_GET['order'] ) && 'desc' == $_GET['order'] ) {
+        if ( isset( $_GET['order'] ) && 'desc' === $_GET['order'] ) {
             $current_order = 'desc';
         } else {
-            // The initial view is not always 'asc' we'll take care of this below.
+            // The initial view is not always 'asc', we'll take care of this below.
             $current_order = 'asc';
         }
@@ -1389 +1389 @@
                 if ( $current_orderby === $orderby ) {
                     // The sorted column. The `aria-sort` attribute must be set only on the sorted column.
-                    if ( 'asc' == $current_order ) {
+                    if ( 'asc' === $current_order ) {
                         $order          = 'desc';
                         $aria_sort_attr = ' aria-sort="ascending"';
@@ -1396 +1396 @@
                         $aria_sort_attr = ' aria-sort="descending"';
                     }
+
                     $class[] = 'sorted';
                     $class[] = $current_order;
@@ -1408 +1409 @@
                     $class[] = 'sortable';
                     $class[] = 'desc' === $order ? 'asc' : 'desc';
+
                     /* translators: Hidden accessibility text. */
                     $asc_text = __( 'Sort ascending.' );
@@ -1414 +1416 @@
                     $order_text = 'asc' === $order ? $asc_text : $desc_text;
                 }
+
                 if ( '' !== $order_text ) {
                     $order_text = ' <span class="screen-reader-text">' . $order_text . '</span>';
@@ -1460 +1463 @@
 
         // Not in the initial view and descending order.
-        if ( isset( $_GET['order'] ) && 'desc' == $_GET['order'] ) {
+        if ( isset( $_GET['order'] ) && 'desc' === $_GET['order'] ) {
             $current_order = 'desc';
         } else {
-            // The initial view is not always 'asc' we'll take care of this below.
+            // The initial view is not always 'asc', we'll take care of this below.
             $current_order = 'asc';
         }
@@ -1494 +1497 @@
                  * and true in the sorted views when the actual $_GET['orderby'] is equal to $orderby.
                  */
-                if ( $current_orderby == $orderby ) {
+                if ( $current_orderby === $orderby ) {
                     /* translators: Hidden accessibility text. */
                     $asc_text = __( 'Ascending.' );