Changeset 56303

Timestamp:

07/25/2023 02:33:58 PM (15 months ago)

Author:

audrasjb

Message:

Editor: Fix conditionals in Template Editing Mode.

Previously, Site Editor client-side routing started using only the path query argument for loading non-editor views. The router removed the postType query
argument, which caused an error message to be displayed when the template parts list page was reloaded.

This changeset fixes the issue as it was affecting hybrid themes.

Props Mamaduka, isabel_brison, ramonopoly.
Reviewed by isabel_brison, audrasjb.
Merges [56302] to the 6.3 branch.
Fixes #58889.

Location:

branches/6.3

Files:

• . (modified) (1 prop)
• src/wp-admin/menu.php (modified) (1 diff)
• src/wp-admin/site-editor.php (modified) (1 diff)

branches/6.3/src/wp-admin/menu.php

@@ -211 +211 @@
         __( 'Template Parts' ),
         'edit_theme_options',
-        'site-editor.php?postType=wp_template_part&path=/wp_template_part/all',
+        'site-editor.php?path=/wp_template_part/all',
     );
 }

branches/6.3/src/wp-admin/site-editor.php

@@ -24 +24 @@
 }
 
-$is_template_part_editor = isset( $_GET['postType'] ) && 'wp_template_part' === sanitize_key( $_GET['postType'] );
+$is_template_part = isset( $_GET['postType'] ) && 'wp_template_part' === sanitize_key( $_GET['postType'] );
+$is_template_part_path = isset( $_GET['path'] ) && 'wp_template_partall' === sanitize_key( $_GET['path'] );
+$is_template_part_editor = $is_template_part || $is_template_part_path;
+
 if ( ! wp_is_block_theme() && ! $is_template_part_editor ) {
     wp_die( __( 'The theme you are currently using is not compatible with the Site Editor.' ) );