Changeset 56352

Timestamp:

08/03/2023 12:08:30 PM (18 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use instanceof keyword instead of the is_a() function.

This is a micro-optimization that removes a few unnecessary function calls.

Follow-up to [31188], [34369], [38986], [41159], [43211], [43230], [44606], [45757].

Props ayeshrajans, jrf, rajinsharwar, costdev, mukesh27, SergeyBiryukov.
Fixes #58943.

Location:

trunk

Files:

• src/wp-content/themes/twentyseventeen/inc/template-tags.php (modified) (1 diff)
• src/wp-includes/admin-bar.php (modified) (1 diff)
• src/wp-includes/http.php (modified) (1 diff)
• src/wp-includes/user.php (modified) (2 diffs)
• src/wp-login.php (modified) (1 diff)
• tests/phpunit/includes/testcase-rest-api.php (modified) (1 diff)
• tests/phpunit/tests/actions.php (modified) (1 diff)

trunk/src/wp-content/themes/twentyseventeen/inc/template-tags.php

@@ -141 +141 @@
  */
 function twentyseventeen_front_page_section( $partial = null, $id = 0 ) {
-    if ( is_a( $partial, 'WP_Customize_Partial' ) ) {
+    if ( $partial instanceof WP_Customize_Partial ) {
         // Find out the ID and set it up during a selective refresh.
         global $twentyseventeencounter;

trunk/src/wp-includes/admin-bar.php

@@ -898 +898 @@
                 );
             }
-        } elseif ( is_a( $current_object, 'WP_User' ) && current_user_can( 'edit_user', $current_object->ID ) ) {
+        } elseif ( $current_object instanceof WP_User && current_user_can( 'edit_user', $current_object->ID ) ) {
             $edit_user_link = get_edit_user_link( $current_object->ID );
             if ( $edit_user_link ) {

trunk/src/wp-includes/http.php

@@ -355 +355 @@
     $cookie = wp_remote_retrieve_cookie( $response, $name );
 
-    if ( ! is_a( $cookie, 'WP_Http_Cookie' ) ) {
+    if ( ! ( $cookie instanceof WP_Http_Cookie ) ) {
         return '';
     }

trunk/src/wp-includes/user.php

@@ -4033 +4033 @@
     $request = wp_get_user_request( $request_id );
 
-    if ( ! is_a( $request, 'WP_User_Request' ) || 'request-confirmed' !== $request->status ) {
+    if ( ! ( $request instanceof WP_User_Request ) || 'request-confirmed' !== $request->status ) {
         return;
     }
@@ -4245 +4245 @@
     $request = wp_get_user_request( $request_id );
 
-    if ( ! is_a( $request, 'WP_User_Request' ) || 'request-completed' !== $request->status ) {
+    if ( ! ( $request instanceof WP_User_Request ) || 'request-completed' !== $request->status ) {
         return;
     }

trunk/src/wp-login.php

@@ -1304 +1304 @@
 
             // Check if it is time to add a redirect to the admin email confirmation screen.
-            if ( is_a( $user, 'WP_User' ) && $user->exists() && $user->has_cap( 'manage_options' ) ) {
+            if ( $user instanceof WP_User && $user->exists() && $user->has_cap( 'manage_options' ) ) {
                 $admin_email_lifespan = (int) get_option( 'admin_email_lifespan' );
 

trunk/tests/phpunit/includes/testcase-rest-api.php

@@ -4 +4 @@
     protected function assertErrorResponse( $code, $response, $status = null ) {
 
-        if ( is_a( $response, 'WP_REST_Response' ) ) {
+        if ( $response instanceof WP_REST_Response ) {
             $response = $response->as_error();
         }

trunk/tests/phpunit/tests/actions.php

@@ -536 +536 @@
             foreach ( $filter as $identifier => $function ) {
                 if ( is_array( $function )
-                    && is_a( $function['function'][0], 'MockAction' )
+                    && $function['function'][0] instanceof MockAction
                     && 'action' === $function['function'][1]
                 ) {