Changeset 56356 for trunk/src/wp-admin/includes/class-wp-list-table.php

Timestamp:

08/03/2023 07:50:20 PM (3 years ago)

Author:

hellofromTonya

Message:

Code Modernization: Use "declare" in WP_List_Table magic methods deprecation message

Changes "define" to "declare" in the deprecation message in WP_List_Table magic methods.

Why is "declare" better?
It aligns well to:

• the topic of and published information about dynamic properties.
• the act of explicitly listing the variable as a property on the class.

The goal of this message is guide developers to change their code. Changing the term to "declare" hopefully will aid in the understanding of what is being asked of developers when this deprecation is thrown.

Follow-up [56349].

Props hellofromTonya, antonvlasenko.
Fixes #58896.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -188 +188 @@
 
                 trigger_error(
-                        "The property `{$name}` is not defined. Getting a dynamic (undefined) property is " .
-                        'deprecated since version 6.4.0! Instead, define the property on the class.',
+                        "The property `{$name}` is not declared. Getting a dynamic property is " .
+                        'deprecated since version 6.4.0! Instead, declare the property on the class.',
                         E_USER_DEPRECATED
                 );
@@ -211 +211 @@
 
                 trigger_error(
-                        "The property `{$name}` is not defined. Setting a dynamic (undefined) property is " .
-                        'deprecated since version 6.4.0! Instead, define the property on the class.',
+                        "The property `{$name}` is not declared. Setting a dynamic property is " .
+                        'deprecated since version 6.4.0! Instead, declare the property on the class.',
                         E_USER_DEPRECATED
                 );
@@ -232 +232 @@
 
                 trigger_error(
-                        "The property `{$name}` is not defined. Checking `isset()` on a dynamic (undefined) property " .
-                        'is deprecated since version 6.4.0! Instead, define the property on the class.',
+                        "The property `{$name}` is not declared. Checking `isset()` on a dynamic property " .
+                        'is deprecated since version 6.4.0! Instead, declare the property on the class.',
                         E_USER_DEPRECATED
                 );
@@ -254 +254 @@
 
                 trigger_error(
-                        "A property `{$name}` is not defined. Unsetting a dynamic (undefined) property is " .
-                        'deprecated since version 6.4.0! Instead, define the property on the class.',
+                        "A property `{$name}` is not declared. Unsetting a dynamic property is " .
+                        'deprecated since version 6.4.0! Instead, declare the property on the class.',
                         E_USER_DEPRECATED
                 );