Make WordPress Core


Ignore:
Timestamp:
08/10/2023 04:47:00 PM (10 months ago)
Author:
flixos90
Message:

Editor: Simplify usage of block_has_support() function by supporting a string.

Most block feature checks are for a single feature string, and for such cases it is not intuitive to require an array for the $feature parameter of the block_has_support() function.

This changeset brings it in line with other functions like post_type_supports(), allowing to pass a string for the $feature. An array is still supported for more complex cases where support for sub-features needs to be determined. This change furthermore includes a very minor performance tweak by avoiding calls to the _wp_array_get() function if a single feature string is being checked for.

Props thekt12, nihar007, mukesh27, swissspidy.
Fixes #58532.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/block-supports/settings.php

    r56146 r56382  
    4141    // return early if the block doesn't have support for settings.
    4242    $block_type = WP_Block_Type_Registry::get_instance()->get_registered( $block['blockName'] );
    43     if ( ! block_has_support( $block_type, array( '__experimentalSettings' ), false ) ) {
     43    if ( ! block_has_support( $block_type, '__experimentalSettings', false ) ) {
    4444        return $block_content;
    4545    }
     
    7878    // Return early if the block has not support for descendent block styles.
    7979    $block_type = WP_Block_Type_Registry::get_instance()->get_registered( $block['blockName'] );
    80     if ( ! block_has_support( $block_type, array( '__experimentalSettings' ), false ) ) {
     80    if ( ! block_has_support( $block_type, '__experimentalSettings', false ) ) {
    8181        return null;
    8282    }
Note: See TracChangeset for help on using the changeset viewer.