Changeset 56383 for trunk/tests/phpunit/tests/oembed/template.php

Timestamp:

08/10/2023 07:47:08 PM (16 months ago)

Author:

westonruter

Message:

Embeds: Modernize wp-embed script with removal of obsolete IE10/IE11 code and support for WP<4.4.

• Remove obsolete load event handler in wp-embed since IE10+ support DOMContentLoaded.
• Replace obsolete use of document.createElement('a') in favor of the newer URL class (supported in all browsers but obsolete IE11).
• Remove obsolete IE10/IE11 code.
• Combine conditionals.
• Use substring() instead of deprecated substr() method.
• Eliminate the stipulation that wp-embed.js not include ampersands, considering this was put in place for WP<4.3 which now accounts for only 1.43% of sites. This includes the elimination of the verify:wp-embed grunt task.

Props westonruter, swissspidy.
Fixes #58974.

File:

• trunk/tests/phpunit/tests/oembed/template.php (modified) (1 diff)

trunk/tests/phpunit/tests/oembed/template.php

@@ -344 +344 @@
         $this->assertFalse( $scripts->query( 'wp-embed', 'enqueued' ) );
     }
-
-    /**
-     * Confirms that no ampersands exist in src/wp-includes/js/wp-embed.js.
-     *
-     * See also the `verify:wp-embed` Grunt task for verifying the built file.
-     *
-     * @ticket 34698
-     */
-    public function test_js_no_ampersands() {
-        $this->assertStringNotContainsString( '&', file_get_contents( ABSPATH . WPINC . '/js/wp-embed.js' ) );
-    }
 }