Changeset 56404

Timestamp:

08/17/2023 04:59:49 PM (20 months ago)

Author:

desrosj

Message:

Build/Test Tools: Don’t send a Slack notice when a workflow fails once.

[53947] introduced a callable workflow that allowed a workflow run to be retried automatic. By default all workflows are retried once.

Since a run is not considered “failed” until after the automatic retry, the first Slack message is unnecessary and can cause a lot of noise when there are network hiccups.

This alters the logic to skip a failure notice in Slack until the second failure.

See #58867.

File:

• trunk/.github/workflows/slack-notifications.yml (modified) (2 diffs)

trunk/.github/workflows/slack-notifications.yml

@@ -72 +72 @@
             });
 
+            // All workflows will restart once when a failure is encountered. Don't notify Slack on the first failure.
+            if ( '${{ inputs.calling_status }}' == 'failure' && workflow_run.data.run_attempt == 1 ) {
+              return 'first-failure';
+            }
+
             // When a workflow has been restarted to fix a failure, check the previous run attempt.
             if ( workflow_run.data.run_attempt > 1 ) {
@@ -158 +163 @@
     timeout-minutes: 5
     needs: [ prepare ]
-    if: ${{ inputs.calling_status == 'failure' || failure() }}
+    if: ${{ ( inputs.calling_status == 'failure' || failure() ) && steps.previous-attempt-result.outputs.result != 'first-failure' }}
 
     steps: