WordPress.org
Get WordPress

Make WordPress Core


Ignore:
Timestamp:
08/21/2023 03:53:04 PM (17 months ago)
Author:
SergeyBiryukov
Message:

Build/Test Tools: Update PHPUnit Polyfills to version 1.1.0.

​PHPUnit 9.6.1 deprecated the assertObjectHasAttribute() and assertObjectNotHasAttribute() methods, leading to deprecation notices in a number of tests.

​PHPUnit 10.1.0 brought the methods back by popular request, though renamed as assertObjectHasProperty() and assertObjectNotHasProperty(), to prevent confusion with PHP 8.0 attributes.

This meant that users which cannot (yet) upgrade to PHPUnit 10.1+ would always have deprecation notices for these methods without recourse. So, after much discussion, the new methods have been backported to ​PHPUnit 9.6.11, leaving just the 10.0.x series with a deprecation notice and no recourse.

What does this mean for WordPress?

WordPress uses the ​PHPUnit Polyfills to be able to write tests for the most recent versions of PHPUnit, with the Polyfills taking care of polyfilling any new PHPUnit methods on older PHPUnit versions.

  • The PHPUnit Polyfills 1.x series supports PHPUnit 4.x to 9.x.
  • The PHPUnit Polyfills 2.x series supports PHPUnit 5.x to 10.x.

WordPress currently runs against PHPUnit 6.x to 9.x with PHPUnit Polyfills 1.x, while the new methods were previously only included in PHPUnit Polyfills 2.0.0+, as they were introduced in PHPUnit 10.x.

Since the assertObjectHasProperty() and assertObjectNotHasProperty() methods have been backported to PHPUnit 9.x, the PHPUnit Polyfills will now include these methods in the 1.x series as well.

By upgrading to the latest ​PHPUnit Polyfills 1.1.0 release, we can get rid of the deprecation notices related to the use of the assertObjectHasAttribute() and assertObjectNotHasAttribute() methods.

This could have implications for plugins or themes running integration tests with WordPress if they have set their PHPUnit Polyfills dependency to a fixed version or have a too strict version constraint (limiting the PHPUnit Polyfills to the 1.0.x series). The solution for those plugins or themes is to update their version constraints for the PHPUnit Polyfills to allow for the 1.1.x series.

Follow-up to [51559], [51598].

Props jrf, ayeshrajans.
Fixes #59150.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/tests/phpunit/tests/customize/nav-menu-item-setting.php

    r54865 r56421  
    927927        $this->assertSame( 'Custom Label', $nav_menu_item->type_label );
    928928
    929         $this->assertObjectNotHasAttribute( 'nav_menu_term_id', $nav_menu_item );
    930         $this->assertObjectNotHasAttribute( 'status', $nav_menu_item );
     929        $this->assertObjectNotHasProperty( 'nav_menu_term_id', $nav_menu_item );
     930        $this->assertObjectNotHasProperty( 'status', $nav_menu_item );
    931931        $this->assertSame( 'publish', $nav_menu_item->post_status );
    932932        $this->assertSame( 'nav_menu_item', $nav_menu_item->post_type );
    933         $this->assertObjectNotHasAttribute( 'position', $nav_menu_item );
     933        $this->assertObjectNotHasProperty( 'position', $nav_menu_item );
    934934        $this->assertSame( $post_value['position'], $nav_menu_item->menu_order );
    935935        $this->assertSame( $post_value['title'], $nav_menu_item->post_title );
    … …  
    937937        $this->assertSame( 123, $nav_menu_item->db_id );
    938938        $this->assertSame( wp_get_current_user()->ID, $nav_menu_item->post_author );
    939         $this->assertObjectHasAttribute( 'type_label', $nav_menu_item );
     939        $this->assertObjectHasProperty( 'type_label', $nav_menu_item );
    940940        $expected = apply_filters( 'nav_menu_attr_title', wp_unslash( apply_filters( 'excerpt_save_pre', wp_slash( $post_value['attr_title'] ) ) ) );
    941941        $this->assertSame( $expected, $nav_menu_item->attr_title );
    … …  
    10711071        $this->assertSame( '', $item_value['title'] );
    10721072        $item = $setting->value_as_wp_post_nav_menu_item();
    1073         $this->assertObjectHasAttribute( 'type_label', $item );
     1073        $this->assertObjectHasProperty( 'type_label', $item );
    10741074        $this->assertSame( $original_post_title, $item->original_title );
    10751075        $this->assertSame( $original_post_title, $item->title );
    … …  
    10981098        $this->assertSame( '', $item_value['title'] );
    10991099        $item = $setting->value_as_wp_post_nav_menu_item();
    1100         $this->assertObjectHasAttribute( 'type_label', $item );
     1100        $this->assertObjectHasProperty( 'type_label', $item );
    11011101        $this->assertSame( $original_post_title, $item->original_title );
    11021102        $this->assertSame( $original_post_title, $item->title );
    … …  
    11251125        $this->assertSame( '', $item_value['title'] );
    11261126        $item = $setting->value_as_wp_post_nav_menu_item();
    1127         $this->assertObjectHasAttribute( 'type_label', $item );
     1127        $this->assertObjectHasProperty( 'type_label', $item );
    11281128        $this->assertSame( $original_term_title, $item->original_title );
    11291129        $this->assertSame( $original_term_title, $item->title );
    … …  
    11521152        $this->assertSame( '', $item_value['title'] );
    11531153        $item = $setting->value_as_wp_post_nav_menu_item();
    1154         $this->assertObjectHasAttribute( 'type_label', $item );
     1154        $this->assertObjectHasProperty( 'type_label', $item );
    11551155        $this->assertSame( $original_term_title, $item->original_title );
    11561156        $this->assertSame( $original_term_title, $item->title );
    … …  
    11781178        $this->assertSame( '', $item_value['title'] );
    11791179        $item = $setting->value_as_wp_post_nav_menu_item();
    1180         $this->assertObjectHasAttribute( 'type_label', $item );
     1180        $this->assertObjectHasProperty( 'type_label', $item );
    11811181        $this->assertSame( get_post_type_object( 'press_release' )->labels->archives, $item->original_title );
    11821182        $this->assertSame( get_post_type_object( 'press_release' )->labels->archives, $item->title );
    … …  
    12041204        $this->assertSame( '', $item_value['title'] );
    12051205        $item = $setting->value_as_wp_post_nav_menu_item();
    1206         $this->assertObjectHasAttribute( 'type_label', $item );
     1206        $this->assertObjectHasProperty( 'type_label', $item );
    12071207        $this->assertSame( get_post_type_object( 'press_release' )->labels->archives, $item->original_title );
    12081208        $this->assertSame( get_post_type_object( 'press_release' )->labels->archives, $item->title );
Note: See TracChangeset for help on using the changeset viewer.