Changeset 56423 for branches/6.3/src/wp-includes/blocks/footnotes.php

Timestamp:

08/22/2023 09:57:53 AM (3 years ago)

Author:

audrasjb

Message:

Editor: update npm packages with critical bug fixes for 6.3.1.

Includes fixes for footnotes and editor styles related crashes, as well as a cut and paste-related crash.

This changeset partially merges [56419] to the 6.3 branch as the package-lock had to be rebuilt due to the release branch still using node 14.x.x, and some manual
editing was necessary due to the unresolved floating-ui dependency issue.

Props ramonopoly, isabel_brison.
Reviewed by azaozz, audrasjb.
Merges [56419] to the 6.3 branch.
See #59151.

File:

• branches/6.3/src/wp-includes/blocks/footnotes.php (modified) (6 diffs)

branches/6.3/src/wp-includes/blocks/footnotes.php

@@ -35 +35 @@
         $footnotes = json_decode( $footnotes, true );
 
-        if ( count( $footnotes ) === 0 ) {
+        if ( ! is_array( $footnotes ) || count( $footnotes ) === 0 ) {
                 return '';
         }
@@ -99 +99 @@
                 if ( $footnotes ) {
                         // Can't use update_post_meta() because it doesn't allow revisions.
-                        update_metadata( 'post', $revision_id, 'footnotes', $footnotes );
+                        update_metadata( 'post', $revision_id, 'footnotes', wp_slash( $footnotes ) );
                 }
         }
@@ -155 +155 @@
                         if ( $footnotes ) {
                                 // Can't use update_post_meta() because it doesn't allow revisions.
-                                update_metadata( 'post', $wp_temporary_footnote_revision_id, 'footnotes', $footnotes );
+                                update_metadata( 'post', $wp_temporary_footnote_revision_id, 'footnotes', wp_slash( $footnotes ) );
                         }
                 }
@@ -161 +161 @@
 }
 
-foreach ( array( 'post', 'page' ) as $post_type ) {
-        add_action( "rest_after_insert_{$post_type}", 'wp_add_footnotes_revisions_to_post_meta' );
-}
+add_action( 'rest_after_insert_post', 'wp_add_footnotes_revisions_to_post_meta' );
+add_action( 'rest_after_insert_page', 'wp_add_footnotes_revisions_to_post_meta' );
 
 /**
@@ -177 +176 @@
 
         if ( $footnotes ) {
-                update_post_meta( $post_id, 'footnotes', $footnotes );
+                update_post_meta( $post_id, 'footnotes', wp_slash( $footnotes ) );
         } else {
                 delete_post_meta( $post_id, 'footnotes' );
@@ -244 +243 @@
         }
 
-        update_post_meta( $id, 'footnotes', $body['meta']['footnotes'] );
+        update_post_meta( $id, 'footnotes', wp_slash( $body['meta']['footnotes'] ) );
 }
 // See https://github.com/WordPress/wordpress-develop/blob/2103cb9966e57d452c94218bbc3171579b536a40/src/wp-includes/rest-api/endpoints/class-wp-rest-autosaves-controller.php#L391C1-L391C1.