Changeset 56424 for trunk/src/wp-includes/post-template.php

Timestamp:

08/22/2023 12:28:52 PM (14 months ago)

Author:

SergeyBiryukov

Message:

Posts, Post Types: Remove redundant function calls in get_body_class().

As part of a previous change to add support for post type templates, the $wp_query->get_queried_object_id() method ended up being called twice, in both the is_singular() and is_page() conditional branches.

The get_post() function call was also unnecessary, as $wp_query->get_queried_object() is already called in the is_singular() branch above, which includes the is_page() branch too.

This commit removes the redundant calls. The first $wp_query->get_queried_object_id() call is removed as well, since the post ID is already available via $wp_query->get_queried_object().

Follow-up to [10485], [10877], [12877], [13032], [21597], [38951].

Props mattkeys, spacedmonkey, oglekler.
Fixes #43661.

File:

• trunk/src/wp-includes/post-template.php (modified) (2 diffs)

trunk/src/wp-includes/post-template.php

@@ -671 +671 @@
 
     if ( is_singular() ) {
-        $post_id   = $wp_query->get_queried_object_id();
         $post      = $wp_query->get_queried_object();
+        $post_id   = $post->ID;
         $post_type = $post->post_type;
 
@@ -715 +715 @@
         } elseif ( is_page() ) {
             $classes[] = 'page';
-
-            $page_id = $wp_query->get_queried_object_id();
-
-            $post = get_post( $page_id );
-
-            $classes[] = 'page-id-' . $page_id;
+            $classes[] = 'page-id-' . $post_id;
 
             if ( get_pages(
                 array(
-                    'parent' => $page_id,
+                    'parent' => $post_id,
                     'number' => 1,
                 )