Changeset 56455 for trunk/src/wp-includes/blocks.php

Timestamp:

08/24/2023 07:36:16 PM (14 months ago)

Author:

antpb

Message:

Performance: Add fallback for $script_uri to prevent firing plugins_url() unnecessarily.

Previously, in register_block_script_handle() the $script_uri variable initialized with a plugins_url() call that was reported to invoke four times. In this patch the var is initialized as a blank string with a fallback to use the plugins_url() if the other intended conditions are not met.

Props mukesh27, daxelrod, adamsilverstein, davidbaumwald.
Fixes #59181.

File:

• trunk/src/wp-includes/blocks.php (modified) (2 diffs)

trunk/src/wp-includes/blocks.php

@@ -155 +155 @@
     $is_theme_block        = ( $is_parent_theme_block || $is_child_theme_block );
 
-    $script_uri = plugins_url( $script_path, $metadata['file'] );
+    $script_uri = '';
     if ( $is_core_block ) {
         $script_uri = includes_url( str_replace( $wpinc_path_norm, '', $script_path_norm ) );
@@ -163 +163 @@
             ? get_theme_file_uri( str_replace( $template_path_norm, '', $script_path_norm ) )
             : get_theme_file_uri( str_replace( $stylesheet_path_norm, '', $script_path_norm ) );
+    } else {
+        // Fallback to plugins_url().
+        $script_uri = plugins_url( $script_path, $metadata['file'] );
     }