Changeset 56469

Timestamp:

08/25/2023 03:35:59 AM (3 years ago)

Author:

DrewAPicture

Message:

Properly deprecate both constructors in WP_User_Search.

• __construct() gets the new _deprecated_class() function
• WP_User_Search PHP4 style constructor is changed from _deprecated_function() to _deprecated_constructor()

Adds a test to confirm WP_User_Search class is testable as deprecated.

Props jrf, DrewAPicture.
Fixes #41125.

Location:

trunk

Files:

• src/wp-admin/includes/deprecated.php (modified) (2 diffs)
• tests/phpunit/tests/admin/wpUserSearch.php (added)

trunk/src/wp-admin/includes/deprecated.php

@@ -494 +494 @@
          */
         function __construct( $search_term = '', $page = '', $role = '' ) {
-                _deprecated_function( __FUNCTION__, '3.1.0', 'WP_User_Query' );
+                _deprecated_class( 'WP_User_Search', '3.1.0', 'WP_User_Query' );
 
                 $this->search_term = wp_unslash( $search_term );
@@ -517 +517 @@
          */
         public function WP_User_Search( $search_term = '', $page = '', $role = '' ) {
+                _deprecated_constructor( 'WP_User_Search', '3.1.0', get_class( $this ) );
                 self::__construct( $search_term, $page, $role );
         }