Changeset 56478

Timestamp:

08/27/2023 12:21:33 PM (13 months ago)

Author:

johnbillion

Message:

Users: Call add_user_meta() instead of update_user_meta() when adding metadata to a new user.

This improves the performance of inserting users as it removes one unnecessary SELECT query for every row of metadata inserted.

Props swissspidy, spacedmonkey, johnbillion

Fixes #59212

File:

• trunk/src/wp-includes/user.php (modified) (1 diff)

trunk/src/wp-includes/user.php

@@ -2432 +2432 @@
     $meta = array_merge( $meta, $custom_meta );
 
-    // Update user meta.
-    foreach ( $meta as $key => $value ) {
-        update_user_meta( $user_id, $key, $value );
+    if ( $update ) {
+        // Update user meta.
+        foreach ( $meta as $key => $value ) {
+            update_user_meta( $user_id, $key, $value );
+        }
+    } else {
+        // Add user meta.
+        foreach ( $meta as $key => $value ) {
+            add_user_meta( $user_id, $key, $value );
+        }
     }