Changeset 56490 for trunk/src/wp-includes/post.php

Timestamp:

08/29/2023 10:03:25 PM (16 months ago)

Author:

joemcgill

Message:

Posts, Post Types: Reinstate missing sort_column options in get_pages().

This fixes an issue introduced in [55569] that broke sort ordering by post_modified_gmt or modified_gmt.

Props david.binda, azaozz, spacedmonkey, flixos90, joemcgill.
Fixes #59226.

File:

• trunk/src/wp-includes/post.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -6067 +6067 @@
     }
 
+    /*
+     * Maintain backward compatibility for `sort_column` key.
+     * Additionally to `WP_Query`, it has been supporting the `post_modified_gmt` field, so this logic will translate
+     * it to `post_modified` which should result in the same order given the two dates in the fields match.
+     */
     $orderby = wp_parse_list( $parsed_args['sort_column'] );
-    $orderby = array_map( 'trim', $orderby );
+    $orderby = array_map(
+        static function( $orderby_field ) {
+            $orderby_field = trim( $orderby_field );
+            if ( 'post_modified_gmt' === $orderby_field || 'modified_gmt' === $orderby_field ) {
+                $orderby_field = str_replace( '_gmt', '', $orderby_field );
+            }
+            return $orderby_field;
+        },
+        $orderby
+    );
     if ( $orderby ) {
         $query_args['orderby'] = array_fill_keys( $orderby, $parsed_args['sort_order'] );