Changeset 56492

Timestamp:

08/30/2023 10:49:27 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Correct uses of ReflectionProperty::setValue() for static properties.

The single parameter signature, which was used for setting the value on a static property, is deprecated since PHP 8.3. A cross-version solution is to pass null as the first parameter.

This commit updates all the instances that use the deprecated signature in WordPress core.

Reference: ​PHP RFC: Deprecate functions with overloaded signatures: ReflectionProperty::setValue().

Follow-up to [53152], [54493], [54799].

Props jrf, costdev, Tests: Correct uses of ReflectionProperty::setValue() for static properties.

The single parameter signature, which was used for setting the value on a static property, is deprecated since PHP 8.3. A cross-version solution is to pass null as the first parameter.

This commit updates all the instances that use the deprecated signature in WordPress core.

Reference: ​PHP RFC: Deprecate functions with overloaded signatures: ReflectionProperty::setValue().

Follow-up to [53152], [54493], [54799].

Props jrf, costdev, sc0ttkclark.
See #59231.

Location:

trunk/tests/phpunit/tests

Files:

• rest-api/wpRestBlockPatternCategoriesController.php (modified) (2 diffs)
• rest-api/wpRestBlockPatternsController.php (modified) (2 diffs)
• theme/wpThemeJsonResolver.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rest-api/wpRestBlockPatternCategoriesController.php

@@ -66 +66 @@
                 self::$registry_instance_property->setAccessible( true );
                 $test_registry = new WP_Block_Pattern_Categories_Registry();
-                self::$registry_instance_property->setValue( $test_registry );
+                self::$registry_instance_property->setValue( null, $test_registry );
 
                 // Register some categories in the test registry.
@@ -89 +89 @@
 
                 // Restore the original registry instance.
-                self::$registry_instance_property->setValue( self::$orig_registry );
+                self::$registry_instance_property->setValue( null, self::$orig_registry );
                 self::$registry_instance_property->setAccessible( false );
                 self::$registry_instance_property = null;

trunk/tests/phpunit/tests/rest-api/wpRestBlockPatternsController.php

@@ -66 +66 @@
                 self::$registry_instance_property->setAccessible( true );
                 $test_registry = new WP_Block_Pattern_Categories_Registry();
-                self::$registry_instance_property->setValue( $test_registry );
+                self::$registry_instance_property->setValue( null, $test_registry );
 
                 // Register some patterns in the test registry.
@@ -107 +107 @@
 
                 // Restore the original registry instance.
-                self::$registry_instance_property->setValue( self::$orig_registry );
+                self::$registry_instance_property->setValue( null, self::$orig_registry );
                 self::$registry_instance_property->setAccessible( false );
                 self::$registry_instance_property = null;

trunk/tests/phpunit/tests/theme/wpThemeJsonResolver.php

@@ -82 +82 @@
 
         public static function tear_down_after_class() {
-                static::$property_blocks_cache->setValue( WP_Theme_JSON_Resolver::class, static::$property_blocks_cache_orig_value );
-                static::$property_core->setValue( WP_Theme_JSON_Resolver::class, static::$property_core_orig_value );
+                static::$property_blocks_cache->setValue( null, static::$property_blocks_cache_orig_value );
+                static::$property_core->setValue( null, static::$property_core_orig_value );
                 parent::tear_down_after_class();
         }
@@ -760 +760 @@
                 $property = new ReflectionProperty( $theme_json_resolver, 'i18n_schema' );
                 $property->setAccessible( true );
-                $property->setValue( null );
+                $property->setValue( null, null );
 
                 // A completely empty theme.json data set still has the 'version' key when parsed.