Changeset 56493 for trunk/src/wp-includes/html-api/class-wp-html-processor.php

Timestamp:

08/30/2023 03:37:33 PM (13 months ago)

Author:

Bernhard Reiter

Message:

HTML API: Stop processing HTML when encountering unsupported markup.

It was a design goal of the HTML Processor to abort processing its input document when encountering unsupported markup. Unfortunately there was no test for this and so-far, the HTML Processor has paused, but continued processing in these situations.

In this patch a new test ensures that the HTML Processor stops and refuses to move forward after encountering any unsupported markup. It also ensures that it doesn't report any current tag names since unsupported markup could imply that the read tag name is different than the parsed tag name.

Props dmsnell.
Fixes #59167.

File:

• trunk/src/wp-includes/html-api/class-wp-html-processor.php (modified) (2 diffs)

trunk/src/wp-includes/html-api/class-wp-html-processor.php

@@ -433 +433 @@
      */
     public function step( $node_to_process = self::PROCESS_NEXT_NODE ) {
+        // Refuse to proceed if there was a previous error.
+        if ( null !== $this->last_error ) {
+            return false;
+        }
+
         if ( self::PROCESS_NEXT_NODE === $node_to_process ) {
             $top_node = $this->state->stack_of_open_elements->current_node();
@@ -745 +750 @@
      */
     public function get_tag() {
+        if ( null !== $this->last_error ) {
+            return null;
+        }
+
         $tag_name = parent::get_tag();