Changeset 56502 for trunk/tests/phpunit/tests/theme/wpThemeJson.php

Timestamp:

09/01/2023 02:51:55 AM (3 years ago)

Author:

isabel_brison

Message:

Editor: Preserve block style variations when securing theme.

Adds the ability to process block style variations to the remove_insecure_properties function of theme json class.

Props dsas, ramonopoly.
Fixes #59108.

File:

• trunk/tests/phpunit/tests/theme/wpThemeJson.php (modified) (1 diff)

trunk/tests/phpunit/tests/theme/wpThemeJson.php

@@ -3870 +3870 @@
         }
 
+        public function test_block_style_variations() {
+                wp_set_current_user( static::$administrator_id );
+
+                $expected = array(
+                        'version' => WP_Theme_JSON::LATEST_SCHEMA,
+                        'styles'  => array(
+                                'blocks' => array(
+                                        'core/button' => array(
+                                                'color'      => array(
+                                                        'background' => 'blue',
+                                                ),
+                                                'variations' => array(
+                                                        'outline' => array(
+                                                                'color' => array(
+                                                                        'background' => 'purple',
+                                                                ),
+                                                        ),
+                                                ),
+                                        ),
+                                ),
+                        ),
+                );
+
+                $actual = WP_Theme_JSON::remove_insecure_properties( $expected );
+
+                $this->assertSameSetsWithIndex( $expected, $actual );
+        }
+
+        public function test_block_style_variations_with_invalid_properties() {
+                wp_set_current_user( static::$administrator_id );
+
+                $partially_invalid_variation = array(
+                        'version' => WP_Theme_JSON::LATEST_SCHEMA,
+                        'styles'  => array(
+                                'blocks' => array(
+                                        'core/button' => array(
+                                                'color'      => array(
+                                                        'background' => 'blue',
+                                                ),
+                                                'variations' => array(
+                                                        'outline' => array(
+                                                                'color'   => array(
+                                                                        'background' => 'purple',
+                                                                ),
+                                                                'invalid' => array(
+                                                                        'value' => 'should be stripped',
+                                                                ),
+                                                        ),
+                                                ),
+                                        ),
+                                ),
+                        ),
+                );
+
+                $expected = array(
+                        'version' => WP_Theme_JSON::LATEST_SCHEMA,
+                        'styles'  => array(
+                                'blocks' => array(
+                                        'core/button' => array(
+                                                'color'      => array(
+                                                        'background' => 'blue',
+                                                ),
+                                                'variations' => array(
+                                                        'outline' => array(
+                                                                'color' => array(
+                                                                        'background' => 'purple',
+                                                                ),
+                                                        ),
+                                                ),
+                                        ),
+                                ),
+                        ),
+                );
+
+                $actual = WP_Theme_JSON::remove_insecure_properties( $partially_invalid_variation );
+
+                $this->assertSameSetsWithIndex( $expected, $actual );
+        }
+
         /**
          * @ticket 56611