Changeset 56503

Timestamp:

09/01/2023 04:01:23 AM (13 months ago)

Author:

isabel_brison

Message:

Editor: Don't use fluid layout value in typography.

Changes fluid typography calculation to use fallback value if layout wide size is a fluid value.

Props ramonopoly, mukesh27, jastos, aurooba.
See #58754.

Location:

trunk

Files:

• src/wp-includes/block-supports/typography.php (modified) (1 diff)
• tests/phpunit/data/themedir1/block-theme-child-with-fluid-layout (added)
• tests/phpunit/data/themedir1/block-theme-child-with-fluid-layout/style.css (added)
• tests/phpunit/data/themedir1/block-theme-child-with-fluid-layout/theme.json (added)
• tests/phpunit/tests/block-supports/typography.php (modified) (1 diff)
• tests/phpunit/tests/theme/themeDir.php (modified) (1 diff)

trunk/src/wp-includes/block-supports/typography.php

@@ -518 +518 @@
 
     // Defaults.
-    $default_maximum_viewport_width       = isset( $layout_settings['wideSize'] ) ? $layout_settings['wideSize'] : '1600px';
+    $default_maximum_viewport_width       = isset( $layout_settings['wideSize'] ) && ! empty( wp_get_typography_value_and_unit( $layout_settings['wideSize'] ) ) ? $layout_settings['wideSize'] : '1600px';
     $default_minimum_viewport_width       = '320px';
     $default_minimum_font_size_factor_max = 0.75;

trunk/tests/phpunit/tests/block-supports/typography.php

@@ -700 +700 @@
                 'expected_output' => 'font-size:15px;',
             ),
+            'returns clamp value using default config if layout is fluid' => array(
+                'font_size_value' => '15px',
+                'theme_slug'      => 'block-theme-child-with-fluid-layout',
+                'expected_output' => 'font-size:clamp(14px, 0.875rem + ((1vw - 3.2px) * 0.078), 15px);',
+            ),
         );
     }

trunk/tests/phpunit/tests/theme/themeDir.php

@@ -180 +180 @@
             'Block Theme Child Theme',
             'Block Theme Child with no theme.json',
+            'Block Theme Child Theme With Fluid Layout',
             'Block Theme Child Theme With Fluid Typography',
             'Block Theme Child Theme With Fluid Typography Config',