Changeset 56514 for trunk/src/wp-includes/functions.php

Timestamp:

09/05/2023 12:22:44 PM (14 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in wp-includes/functions.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $class parameter to $class_name in _deprecated_class().

Follow-up to [54929], [56467].

Props jrf.
See #59161.

File:

• trunk/src/wp-includes/functions.php (modified) (6 diffs)

trunk/src/wp-includes/functions.php

@@ -5626 +5626 @@
  * @since 6.4.0
  *
- * @param string $class       The class being instantiated.
+ * @param string $class_name  The name of the class being instantiated.
  * @param string $version     The version of WordPress that deprecated the class.
  * @param string $replacement Optional. The class or function that should have been called.
  *                            Default empty string.
  */
-function _deprecated_class( $class, $version, $replacement = '' ) {
+function _deprecated_class( $class_name, $version, $replacement = '' ) {
 
     /**
@@ -5638 +5638 @@
      * @since 6.4.0
      *
-     * @param string $class       The class being instantiated.
+     * @param string $class_name  The name of the class being instantiated.
      * @param string $replacement The class or function that should have been called.
      * @param string $version     The version of WordPress that deprecated the class.
      */
-    do_action( 'deprecated_class_run', $class, $replacement, $version );
+    do_action( 'deprecated_class_run', $class_name, $replacement, $version );
 
     /**
@@ -5658 +5658 @@
                         /* translators: 1: PHP class name, 2: Version number, 3: Alternative class or function name. */
                         __( 'Class %1$s is <strong>deprecated</strong> since version %2$s! Use %3$s instead.' ),
-                        $class,
+                        $class_name,
                         $version,
                         $replacement
@@ -5669 +5669 @@
                         /* translators: 1: PHP class name, 2: Version number. */
                         __( 'Class %1$s is <strong>deprecated</strong> since version %2$s with no alternative available.' ),
-                        $class,
+                        $class_name,
                         $version
                     ),
@@ -5680 +5680 @@
                     sprintf(
                         'Class %1$s is <strong>deprecated</strong> since version %2$s! Use %3$s instead.',
-                        $class,
+                        $class_name,
                         $version,
                         $replacement
@@ -5690 +5690 @@
                     sprintf(
                         'Class %1$s is <strong>deprecated</strong> since version %2$s with no alternative available.',
-                        $class,
+                        $class_name,
                         $version
                     ),