Changeset 56517

Timestamp:

09/05/2023 08:46:19 PM (13 months ago)

Author:

flixos90

Message:

Posts, Post Types: Reinstate missing sort_column options in get_pages().

This fixes an issue introduced in [55569] that broke sort ordering by post_modified_gmt or modified_gmt.

Props david.binda, azaozz, spacedmonkey, flixos90, joemcgill.
Merges [56490] to the 6.3 branch.
Fixes #59226.

Location:

branches/6.3

Files:

• . (modified) (1 prop)
• src/wp-includes/post.php (modified) (1 diff)
• tests/phpunit/tests/post/getPages.php (modified) (1 diff)

branches/6.3/src/wp-includes/post.php

@@ -6067 +6067 @@
     }
 
+    /*
+     * Maintain backward compatibility for `sort_column` key.
+     * Additionally to `WP_Query`, it has been supporting the `post_modified_gmt` field, so this logic will translate
+     * it to `post_modified` which should result in the same order given the two dates in the fields match.
+     */
     $orderby = wp_parse_list( $parsed_args['sort_column'] );
-    $orderby = array_map( 'trim', $orderby );
+    $orderby = array_map(
+        static function( $orderby_field ) {
+            $orderby_field = trim( $orderby_field );
+            if ( 'post_modified_gmt' === $orderby_field || 'modified_gmt' === $orderby_field ) {
+                $orderby_field = str_replace( '_gmt', '', $orderby_field );
+            }
+            return $orderby_field;
+        },
+        $orderby
+    );
     if ( $orderby ) {
         $query_args['orderby'] = array_fill_keys( $orderby, $parsed_args['sort_order'] );

branches/6.3/tests/phpunit/tests/post/getPages.php

@@ -1182 +1182 @@
         );
     }
+
+    /**
+     * Tests that the legacy `post_modified_gmt` orderby values are translated to the proper `WP_Query` values.
+     *
+     * @ticket 59226
+     */
+    public function test_get_pages_order_by_post_modified_gmt() {
+        global $wpdb;
+
+        get_pages(
+            array(
+                'sort_column' => 'post_modified_gmt',
+            )
+        );
+        $this->assertStringContainsString(
+            "ORDER BY $wpdb->posts.post_modified ASC",
+            $wpdb->last_query,
+            'Check that ORDER is post modified when using post_modified_gmt.'
+        );
+
+        get_pages(
+            array(
+                'sort_column' => 'modified_gmt',
+            )
+        );
+        $this->assertStringContainsString(
+            "ORDER BY $wpdb->posts.post_modified ASC",
+            $wpdb->last_query,
+            'Check that ORDER is post modified when using modified_gmt.'
+        );
+    }
 }