Changeset 56543

Timestamp:

09/07/2023 08:43:48 PM (17 months ago)

Author:

hellofromTonya

Message:

Code Modernization: Use wp_trigger_error() in WP_User_Query magic methods.

Replaces trigger_error() with wp_trigger_error() in each of the WP_User_Query magic methods.

[56353] added the dynamic properties deprecation messages to the __get(), __set(), __isset(), __unset() magic methods. Since that commit, wp_trigger_error() was introduced (see [56530]) as a wrapper for trigger_error().

Follow-up to [56353], [56530].

See #58897, #57686.

Location:

trunk

Files:

• src/wp-includes/class-wp-user-query.php (modified) (4 diffs)
• tests/phpunit/tests/user/query.php (modified) (4 diffs)

trunk/src/wp-includes/class-wp-user-query.php

@@ -1123 +1123 @@
         }
 
-        trigger_error(
+        wp_trigger_error(
+            __METHOD__,
             "The property `{$name}` is not declared. Getting a dynamic property is " .
             'deprecated since version 6.4.0! Instead, declare the property on the class.',
@@ -1146 +1147 @@
         }
 
-        trigger_error(
+        wp_trigger_error(
+            __METHOD__,
             "The property `{$name}` is not declared. Setting a dynamic property is " .
             'deprecated since version 6.4.0! Instead, declare the property on the class.',
@@ -1167 +1169 @@
         }
 
-        trigger_error(
+        wp_trigger_error(
+            __METHOD__,
             "The property `{$name}` is not declared. Checking `isset()` on a dynamic property " .
             'is deprecated since version 6.4.0! Instead, declare the property on the class.',
@@ -1189 +1192 @@
         }
 
-        trigger_error(
+        wp_trigger_error(
+            __METHOD__,
             "A property `{$name}` is not declared. Unsetting a dynamic property is " .
             'deprecated since version 6.4.0! Instead, declare the property on the class.',

trunk/tests/phpunit/tests/user/query.php

@@ -2254 +2254 @@
         $this->expectDeprecation();
         $this->expectDeprecationMessage(
+            'WP_User_Query::__get(): ' .
             'The property `undefined_property` is not declared. Getting a dynamic property is ' .
             'deprecated since version 6.4.0! Instead, declare the property on the class.'
@@ -2286 +2287 @@
         $this->expectDeprecation();
         $this->expectDeprecationMessage(
+            'WP_User_Query::__set(): ' .
             'The property `undefined_property` is not declared. Setting a dynamic property is ' .
             'deprecated since version 6.4.0! Instead, declare the property on the class.'
@@ -2322 +2324 @@
         $this->expectDeprecation();
         $this->expectDeprecationMessage(
+            'WP_User_Query::__isset(): ' .
             'The property `undefined_property` is not declared. Checking `isset()` on a dynamic property ' .
             'is deprecated since version 6.4.0! Instead, declare the property on the class.'
@@ -2353 +2356 @@
         $this->expectDeprecation();
         $this->expectDeprecationMessage(
+            'WP_User_Query::__unset(): ' .
             'A property `undefined_property` is not declared. Unsetting a dynamic property is ' .
             'deprecated since version 6.4.0! Instead, declare the property on the class.'